Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/ask-a-question/form/contactInformation/address/address.js

Summary

Maintainability
D
2 days
Test Coverage

Function uiSchema has 202 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function uiSchema(
  label = 'Address',
  useStreet2 = true,
  useStreet3 = false,
  isRequired = null,
Severity: Major
Found in src/applications/ask-a-question/form/contactInformation/address/address.js - About 1 day to fix

    File address.js has 353 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import get from 'platform/utilities/data/get';
import set from 'platform/utilities/data/set';
import unset from 'platform/utilities/data/unset';
import { createSelector } from 'reselect';
    Severity: Minor
    Found in src/applications/ask-a-question/form/contactInformation/address/address.js - About 4 hrs to fix

      Function uiSchema has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      export function uiSchema(
  label = 'Address',
  useStreet2 = true,
  useStreet3 = false,
  isRequired = null,
      Severity: Minor
      Found in src/applications/ask-a-question/form/contactInformation/address/address.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function uiSchema has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        label = 'Address',
  useStreet2 = true,
  useStreet3 = false,
  isRequired = null,
  ignoreRequired = false,
      Severity: Minor
      Found in src/applications/ask-a-question/form/contactInformation/address/address.js - About 35 mins to fix

        Function validatePostalCodes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function validatePostalCodes(errors, address) {
  let isValidPostalCode = true;

  // Checks if postal code is valid
  if (address.country === 'USA') {
        Severity: Minor
        Found in src/applications/ask-a-question/form/contactInformation/address/address.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 8 locations. Consider refactoring.
        Open

        function isMilitaryCity(city = '') {
  const lowerCity = city.toLowerCase().trim();

  return lowerCity === 'apo' || lowerCity === 'fpo' || lowerCity === 'dpo';
}
        Severity: Major
        Found in src/applications/ask-a-question/form/contactInformation/address/address.js and 7 other locations - About 1 hr to fix
        src/applications/ask-va/config/schema-helpers/addressHelper.js on lines 31..35
        src/applications/pre-need-integration/definitions/address.js on lines 102..106
        src/applications/pre-need/definitions/address.js on lines 89..93
        src/applications/simple-forms/shared/definitions/pdfAddress.js on lines 78..82
        src/applications/vaos/new-appointment/fields/addressFields.js on lines 39..43
        src/platform/forms-system/src/js/definitions/address.js on lines 75..79
        src/platform/forms/definitions/address.js on lines 100..104

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (
        country === 'CAN' &&
        addressSchema.properties.state.title !== canadaStateTitle
      ) {
        schemaUpdate.properties = set(
        Severity: Minor
        Found in src/applications/ask-a-question/form/contactInformation/address/address.js and 1 other location - About 55 mins to fix
        src/applications/ask-a-question/form/contactInformation/address/address.js on lines 287..305

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (
        country === 'USA' &&
        addressSchema.properties.postalCode.title !== zipCodeTitle
      ) {
        schemaUpdate.properties = set(
        Severity: Minor
        Found in src/applications/ask-a-question/form/contactInformation/address/address.js and 1 other location - About 55 mins to fix
        src/applications/ask-a-question/form/contactInformation/address/address.js on lines 267..285

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status