Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/check-in/api/local-mock-api/mocks/v2/shared/get.js

Summary

Maintainability
D
2 days
Test Coverage

File get.js has 443 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* istanbul ignore file */
const dateFns = require('date-fns');
const { utcToZonedTime, zonedTimeToUtc, format } = require('date-fns-tz');
const {
  singleAppointment,
Severity: Minor
Found in src/applications/check-in/api/local-mock-api/mocks/v2/shared/get.js - About 6 hrs to fix

    Function createAppointments has 96 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const createAppointments = (
  token = defaultUUID,
  demographicsNeedsUpdate = false,
  demographicsConfirmedAt = null,
  nextOfKinNeedsUpdate = false,
    Severity: Major
    Found in src/applications/check-in/api/local-mock-api/mocks/v2/shared/get.js - About 3 hrs to fix

      Function createUpcomingAppointments has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const createUpcomingAppointments = (token, number = 4) => {
  let appointments;
  if (token === noUpcomingAppointments) {
    appointments = [];
  } else {
      Severity: Minor
      Found in src/applications/check-in/api/local-mock-api/mocks/v2/shared/get.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          return {
    facility,
    kind,
    checkInSteps,
    clinicPhoneNumber,
        Severity: Major
        Found in src/applications/check-in/api/local-mock-api/mocks/v2/shared/get.js and 1 other location - About 3 hrs to fix
        src/applications/check-in/hooks/useStorage.jsx on lines 174..194

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            attributes: {
      status,
      serviceType,
      locationId,
      clinic,
        Severity: Major
        Found in src/applications/check-in/api/local-mock-api/mocks/v2/shared/get.js and 1 other location - About 2 hrs to fix
        src/applications/pensions/config/chapters/05-financial-information/index.js on lines 19..35

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

        module.exports = {
  aboutToExpireUUID,
  checkInTooLateUUID,
  createAppointments,
  createAppointmentsOH,
        Severity: Major
        Found in src/applications/check-in/api/local-mock-api/mocks/v2/shared/get.js and 3 other locations - About 1 hr to fix
        src/applications/mhv-secure-messaging/reducers/index.js on lines 17..30
        src/applications/personalization/profile/components/direct-deposit/DirectDeposit.jsx on lines 172..185
        src/applications/representative-search/containers/SearchPage.jsx on lines 586..599

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status