Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/discharge-wizard/utilities/page-navigation.js

Summary

Maintainability
D
1 day
Test Coverage

Function navigateForward has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

export const navigateForward = (
  SHORT_NAME,
  formResponses,
  router,
  editMode,
Severity: Minor
Found in src/applications/discharge-wizard/utilities/page-navigation.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function navigateForward has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const navigateForward = (
  SHORT_NAME,
  formResponses,
  router,
  editMode,
Severity: Major
Found in src/applications/discharge-wizard/utilities/page-navigation.js - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

            } else if (
          displayConditionsMet(nextShortName, formResponses) &&
          !editMode
        ) {
          if (routeMap[routeMap.length - 1] !== ROUTES?.[nextShortName]) {
    Severity: Major
    Found in src/applications/discharge-wizard/utilities/page-navigation.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                if (routeMap[routeMap.length - 1] !== ROUTES?.[nextShortName]) {
            if (valueHasChanged) {
              const index = routeMap.indexOf(ROUTES[SHORT_NAME]);
              const newRouteMap = routeMap.slice(0, index + 1);
              setRouteMap([...newRouteMap, ROUTES?.[nextShortName]]);
      Severity: Major
      Found in src/applications/discharge-wizard/utilities/page-navigation.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  if (formResponses[nextShortName]) {
            localRoadMap.push(ROUTES?.[nextShortName]);
          }
        Severity: Major
        Found in src/applications/discharge-wizard/utilities/page-navigation.js - About 45 mins to fix

          Function navigateBackward has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          export const navigateBackward = (
  router,
  setRouteMap,
  routeMap,
  shortName,
          Severity: Minor
          Found in src/applications/discharge-wizard/utilities/page-navigation.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                  return;
          Severity: Major
          Found in src/applications/discharge-wizard/utilities/page-navigation.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return;
            Severity: Major
            Found in src/applications/discharge-wizard/utilities/page-navigation.js - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status