Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js

Summary

Maintainability
D
1 day
Test Coverage

Function schoolSearch has 192 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function schoolSearch(state = initialState, action) {
  switch (action.type) {
    case INSTITUTION_SELECTED: {
      const {
        address1,
Severity: Major
Found in src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js - About 7 hrs to fix

    Function schoolSearch has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function schoolSearch(state = initialState, action) {
  switch (action.type) {
    case INSTITUTION_SELECTED: {
      const {
        address1,
    Severity: Minor
    Found in src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return {
        ...state,
        institutionQuery,
        institutions,
        pagesCount,
    Severity: Major
    Found in src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return state;
      Severity: Major
      Found in src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return initialState;
        Severity: Major
        Found in src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return {
        ...state,
        manualSchoolEntryChecked: action.manualSchoolEntryChecked,
      };
          Severity: Major
          Found in src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return {
        ...state,
        searchInputValue: action.searchInputValue,
      };
            Severity: Major
            Found in src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js - About 30 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                        const {
            address1,
            address2,
            address3,
            city,
              Severity: Major
              Found in src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js and 2 other locations - About 1 hr to fix
              src/applications/personalization/profile/components/direct-deposit/AccountUpdateView.jsx on lines 75..85
              src/applications/verify-your-enrollment/helpers.jsx on lines 680..690

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                        return {
            address1,
            address2,
            address3,
            city,
              Severity: Major
              Found in src/applications/edu-benefits/feedback-tool/reducers/schoolSelect.js and 2 other locations - About 40 mins to fix
              src/applications/personalization/profile/hooks/useNotificationSettingsUtils.js on lines 101..111
              src/platform/forms-system/src/js/review/SubmitController.jsx on lines 209..219

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status