Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/enrollment-verification/helpers/index.js

Summary

Maintainability
A
1 hr
Test Coverage

Function mapEnrollmentVerificationsForSubmission has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const mapEnrollmentVerificationsForSubmission = ev => {
  // The enrollments are in order with the most recent first.  Look
  // for the first non-null verificationStatus (or, the most recent
  // month) that was verified as either correct or incorrect.
  const mostRecentVerifiedEnrollmentIndex = ev.enrollmentVerifications.findIndex(
Severity: Minor
Found in src/applications/enrollment-verification/helpers/index.js - About 1 hr to fix

    Function mapEnrollmentVerificationsForSubmission has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    export const mapEnrollmentVerificationsForSubmission = ev => {
  // The enrollments are in order with the most recent first.  Look
  // for the first non-null verificationStatus (or, the most recent
  // month) that was verified as either correct or incorrect.
  const mostRecentVerifiedEnrollmentIndex = ev.enrollmentVerifications.findIndex(
    Severity: Minor
    Found in src/applications/enrollment-verification/helpers/index.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status