Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/facility-locator/actions/locations/fetchLocations.js

Summary

Maintainability
C
1 day
Test Coverage

Function fetchLocations has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const fetchLocations = async (
  address = null,
  bounds,
  locationType,
  serviceType,
Severity: Major
Found in src/applications/facility-locator/actions/locations/fetchLocations.js - About 2 hrs to fix

    Function returnAllCare has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const returnAllCare = async params => {
  const { address, bounds, locationType, page, center, radius } = params;
  const isUrgentCare = locationType === LocationType.URGENT_CARE;
  const vaData = await LocatorApi.searchWithBounds(
    address,
    Severity: Minor
    Found in src/applications/facility-locator/actions/locations/fetchLocations.js - About 2 hrs to fix

      Function fetchLocations has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      export const fetchLocations = async (
  address = null,
  bounds,
  locationType,
  serviceType,
      Severity: Minor
      Found in src/applications/facility-locator/actions/locations/fetchLocations.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

          if (
      (isUrgentCare && (!serviceType || serviceType === 'AllUrgentCare')) ||
      (isEmergencyCare && (!serviceType || serviceType === 'AllEmergencyCare'))
    ) {
      const allCare = await returnAllCare({
      Severity: Major
      Found in src/applications/facility-locator/actions/locations/fetchLocations.js - About 40 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                data.data = dataList.data
          .map(location => {
            const distance =
              center &&
              distBetween(
        Severity: Major
        Found in src/applications/facility-locator/actions/locations/fetchLocations.js and 1 other location - About 1 hr to fix
        src/applications/facility-locator/actions/locations/fetchLocations.js on lines 47..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            data: [...nonVaData.data, ...vaData.data]
      .map(location => {
        const distance =
          center &&
          distBetween(
        Severity: Major
        Found in src/applications/facility-locator/actions/locations/fetchLocations.js and 1 other location - About 1 hr to fix
        src/applications/facility-locator/actions/locations/fetchLocations.js on lines 120..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status