department-of-veterans-affairs/vets-website

View on GitHub
src/applications/financial-status-report/actions/index.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function fetchDebts has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const fetchDebts = async dispatch => {
  const getDebts = () => {
    const options = {
      method: 'GET',
      credentials: 'include',
Severity: Minor
Found in src/applications/financial-status-report/actions/index.js - About 1 hr to fix

    Function fetchFormStatus has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const fetchFormStatus = () => async dispatch => {
      dispatch({
        type: FSR_API_CALL_INITIATED,
      });
      const sessionExpiration = localStorage.getItem('sessionExpiration');
    Severity: Minor
    Found in src/applications/financial-status-report/actions/index.js - About 1 hr to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        const getDebts = () => {
          const options = {
            method: 'GET',
            credentials: 'include',
            headers: {
      Severity: Major
      Found in src/applications/financial-status-report/actions/index.js and 4 other locations - About 2 hrs to fix
      src/applications/personalization/common/actions/notifications.js on lines 16..31
      src/applications/personalization/dashboard/actions/debts.js on lines 26..38
      src/applications/personalization/dashboard/actions/debts.js on lines 90..102
      src/applications/personalization/dashboard/actions/form-status.js on lines 14..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          Sentry.withScope(scope => {
            scope.setExtra('error', error);
            Sentry.captureMessage(`FSR fetchFormStatus failed: ${error.detail}`);
          });
      Severity: Major
      Found in src/applications/financial-status-report/actions/index.js and 4 other locations - About 55 mins to fix
      src/applications/combined-debt-portal/combined/actions/copays.js on lines 60..63
      src/applications/combined-debt-portal/combined/actions/debts.js on lines 80..85
      src/applications/combined-debt-portal/combined/actions/debts.js on lines 139..144
      src/applications/financial-status-report/actions/index.js on lines 96..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          Sentry.withScope(scope => {
            scope.setExtra('error', error);
            Sentry.captureMessage(`FSR fetchDebts failed: ${error.detail}`);
          });
      Severity: Major
      Found in src/applications/financial-status-report/actions/index.js and 4 other locations - About 55 mins to fix
      src/applications/combined-debt-portal/combined/actions/copays.js on lines 60..63
      src/applications/combined-debt-portal/combined/actions/debts.js on lines 80..85
      src/applications/combined-debt-portal/combined/actions/debts.js on lines 139..144
      src/applications/financial-status-report/actions/index.js on lines 52..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const filteredResponse = response.debts
            .filter(debt => approvedDeductionCodes.includes(debt.deductionCode))
            .filter(debt => debt.currentAr > 0)
      Severity: Minor
      Found in src/applications/financial-status-report/actions/index.js and 1 other location - About 40 mins to fix
      src/applications/combined-debt-portal/combined/actions/debts.js on lines 115..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status