Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/financial-status-report/config/chapters/householdAssetsChapter.js

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      vehiclesSummary: {
        path: 'vehicles-summary',
        title: 'Your car or other vehicle',
        uiSchema: {},
        schema: { type: 'object', properties: {} },
Severity: Major
Found in src/applications/financial-status-report/config/chapters/householdAssetsChapter.js and 2 other locations - About 2 hrs to fix
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 137..148
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 169..179

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      streamlinedShortTransitionPage: {
        // Transition page - streamlined short form only
        path: 'skip-questions-explainer',
        title: 'You can skip questions on this form',
        CustomPage: StreamlinedExplainer,
Severity: Major
Found in src/applications/financial-status-report/config/chapters/householdAssetsChapter.js and 1 other location - About 1 hr to fix
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 220..231

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      otherAssetsChecklist: {
        path: 'other-assets-checklist',
        title: 'Other assets options',
        CustomPage: OtherAssetsChecklist,
        CustomPageReview: null,
Severity: Major
Found in src/applications/financial-status-report/config/chapters/householdAssetsChapter.js and 1 other location - About 1 hr to fix
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 181..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      addOtherAsset: {
        path: 'add-other-asset',
        title: 'Add your additional assets',
        CustomPage: AddAsset,
        CustomPageReview: null,
Severity: Major
Found in src/applications/financial-status-report/config/chapters/householdAssetsChapter.js and 3 other locations - About 1 hr to fix
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 108..116
src/applications/financial-status-report/config/chapters/householdIncomeChapter.js on lines 159..167
src/applications/financial-status-report/config/chapters/householdIncomeChapter.js on lines 304..312

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      recreationalVehicles: {
        path: 'recreational-vehicles',
        title: 'Recreational vehicles',
        uiSchema: recreationalVehicles.uiSchema,
        schema: recreationalVehicles.schema,
Severity: Major
Found in src/applications/financial-status-report/config/chapters/householdAssetsChapter.js and 4 other locations - About 40 mins to fix
src/applications/disability-benefits/all-claims/config/form.js on lines 739..745
src/applications/financial-status-report/config/chapters/householdAssetsChapter.js on lines 146..152
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 117..123
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 149..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      vehicles: {
        path: 'vehicles',
        title: 'Your vehicles',
        uiSchema: vehicles.uiSchema,
        schema: vehicles.schema,
Severity: Major
Found in src/applications/financial-status-report/config/chapters/householdAssetsChapter.js and 4 other locations - About 40 mins to fix
src/applications/disability-benefits/all-claims/config/form.js on lines 739..745
src/applications/financial-status-report/config/chapters/householdAssetsChapter.js on lines 178..184
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 117..123
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 149..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          const filteredLiquidAssets = monetaryAssets.filter(
            asset =>
              asset?.name?.toLowerCase() !== 'cash on hand (not in bank)' &&
              asset?.name?.toLowerCase() !==
                'cash in a bank (savings and checkings)',
Severity: Minor
Found in src/applications/financial-status-report/config/chapters/householdAssetsChapter.js and 1 other location - About 35 mins to fix
src/applications/financial-status-report/components/monetary/CashInBank.jsx on lines 146..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        depends: formData =>
          formData.questions.hasVehicle &&
          !formData.assets?.automobiles?.length &&
          !isStreamlinedShortForm(formData),
Severity: Minor
Found in src/applications/financial-status-report/config/chapters/householdAssetsChapter.js and 1 other location - About 30 mins to fix
src/applications/financial-status-report/config/chapters/householdExpensesChapter.js on lines 129..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status