Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/gi/selectors/estimator.js

Summary

Maintainability
D
2 days
Test Coverage

Function getDerivedAttributes has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

export function getDerivedAttributes(constant, eligibility, institution) {
  const your = eligibility;
  const its = institution;
  const chapter = Number(your.giBillChapter);
  let monthlyRate;
Severity: Minor
Found in src/applications/gi/selectors/estimator.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getDerivedAttributes has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function getDerivedAttributes(constant, eligibility, institution) {
  const your = eligibility;
  const its = institution;
  const chapter = Number(your.giBillChapter);
  let monthlyRate;
Severity: Major
Found in src/applications/gi/selectors/estimator.js - About 3 hrs to fix

    Function calculateHousing has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function calculateHousing(constant, eligibility, institution, derived) {
  if (derived.chapter === 31 && derived.isFlightOrCorrespondence) {
    return {
      qualifier: 'per month',
      ratedQualifier: ' / month',
    Severity: Major
    Found in src/applications/gi/selectors/estimator.js - About 2 hrs to fix

      Function calculateTuition has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function calculateTuition(constant, eligibility, institution, derived) {
  if (derived.oldGiBill) {
    return { qualifier: 'per year', value: 0, ratedQualifier: '/ year' };
  }
  if (institution.type === 'ojt') {
      Severity: Minor
      Found in src/applications/gi/selectors/estimator.js - About 1 hr to fix

        Function calculateHousing has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        function calculateHousing(constant, eligibility, institution, derived) {
  if (derived.chapter === 31 && derived.isFlightOrCorrespondence) {
    return {
      qualifier: 'per month',
      ratedQualifier: ' / month',
        Severity: Minor
        Found in src/applications/gi/selectors/estimator.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function calculateTuition has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function calculateTuition(constant, eligibility, institution, derived) {
  if (derived.oldGiBill) {
    return { qualifier: 'per year', value: 0, ratedQualifier: '/ year' };
  }
  if (institution.type === 'ojt') {
        Severity: Minor
        Found in src/applications/gi/selectors/estimator.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return {
      qualifier: 'per month',
      ratedQualifier: ' / month',
      value: 0,
    };
        Severity: Major
        Found in src/applications/gi/selectors/estimator.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return {
      qualifier: 'per month',
      ratedQualifier: ' / month',
      value: Math.round((derived.tier * derived.averageBah) / 2),
    };
          Severity: Major
          Found in src/applications/gi/selectors/estimator.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return {
      qualifier: 'per year',
      ratedQualifier: ' / year',
      value: Math.round(constant.FLTTFCAP * derived.tier),
    };
            Severity: Major
            Found in src/applications/gi/selectors/estimator.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return {
    qualifier: 'per year',
    ratedQualifier: ' / year',
    value: Math.round(constant.TFCAP * derived.tier),
  };
              Severity: Major
              Found in src/applications/gi/selectors/estimator.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return {
      qualifier: '% of instate tuition',
      ratedQualifier: '% in-state',
      value: Math.round(100 * derived.tier),
    };
                Severity: Major
                Found in src/applications/gi/selectors/estimator.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return {
      qualifier: 'per year',
      ratedQualifier: ' / year',
      value: Math.round(constant.CORRESPONDTFCAP * derived.tier),
    };
                  Severity: Major
                  Found in src/applications/gi/selectors/estimator.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return {
      qualifier: 'per month',
      ratedQualifier: ' / month',
      value: Math.round(derived.tier * derived.averageBah),
    };
                    Severity: Major
                    Found in src/applications/gi/selectors/estimator.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                        return {
    qualifier: 'per month',
    ratedQualifier: ' / month',
    value: Math.round(derived.tier * derived.bah),
  };
                      Severity: Major
                      Found in src/applications/gi/selectors/estimator.js - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              if (n <= 2) {
        monthlyRate = constant[`VRE${n}DEPRATE${OJT}`];
      } else {
        monthlyRate =
          constant[`VRE2DEPRATE${OJT}`] +
                        Severity: Major
                        Found in src/applications/gi/selectors/estimator.js and 1 other location - About 2 hrs to fix
                        src/applications/gi/selectors/calculator.js on lines 163..169

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 84.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                          if (institution.country !== 'usa') {
    return {
      qualifier: 'per month',
      ratedQualifier: ' / month',
      value: Math.round(derived.tier * derived.averageBah),
                        Severity: Major
                        Found in src/applications/gi/selectors/estimator.js and 2 other locations - About 55 mins to fix
                        src/applications/gi/selectors/estimator.js on lines 143..149
                        src/applications/gi/selectors/estimator.js on lines 150..156

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 54.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                          if (institution.type === 'flight') {
    return {
      qualifier: 'per year',
      ratedQualifier: ' / year',
      value: Math.round(constant.FLTTFCAP * derived.tier),
                        Severity: Major
                        Found in src/applications/gi/selectors/estimator.js and 2 other locations - About 55 mins to fix
                        src/applications/gi/selectors/estimator.js on lines 150..156
                        src/applications/gi/selectors/estimator.js on lines 217..223

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 54.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                          if (institution.type === 'correspondence') {
    return {
      qualifier: 'per year',
      ratedQualifier: ' / year',
      value: Math.round(constant.CORRESPONDTFCAP * derived.tier),
                        Severity: Major
                        Found in src/applications/gi/selectors/estimator.js and 2 other locations - About 55 mins to fix
                        src/applications/gi/selectors/estimator.js on lines 143..149
                        src/applications/gi/selectors/estimator.js on lines 217..223

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 54.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status