department-of-veterans-affairs/vets-website

View on GitHub
src/applications/income-and-asset-statement/config/chapters/08-trusts/trustPages.js

Summary

Maintainability
F
5 days
Test Coverage

File trustPages.js has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import merge from 'lodash/merge';
import {
  arrayBuilderItemFirstPageTitleUI,
  arrayBuilderItemSubsequentPageTitleUI,

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      text: {
        getItemName: () => 'Trust',
        cardDescription: item =>
          item?.marketValueAtEstablishment && (
            <ul className="u-list-no-bullets vads-u-padding-left--0 vads-u-font-weight--normal">
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 36..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 211.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const informationPage = {
      uiSchema: {
        ...arrayBuilderItemFirstPageTitleUI({
          title: 'Trust',
          nounSingular: options.nounSingular,
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 108..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    const medicalExpensePage = {
      uiSchema: {
        ...arrayBuilderItemSubsequentPageTitleUI('Trust'),
        trustUsedForMedicalExpenses: yesNoUI(
          'Is the trust being used to pay for or to reimburse someone else for your medical expenses?',
    src/applications/income-and-asset-statement/config/chapters/08-trusts/trustPages.js on lines 162..189
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 159..186
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 189..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    const incomePage = {
      uiSchema: {
        ...arrayBuilderItemSubsequentPageTitleUI('Trust'),
        receivingIncomeFromTrust: yesNoUI(
          'Are you receiving income from the trust?',
    src/applications/income-and-asset-statement/config/chapters/08-trusts/trustPages.js on lines 192..219
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 159..186
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 189..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

    const summaryPage = {
      uiSchema: {
        'view:isAddingTrusts': arrayBuilderYesNoUI(
          options,
          {
    src/applications/income-and-asset-statement/config/chapters/03-unassociated-incomes/unassociatedIncomePages.js on lines 82..110
    src/applications/income-and-asset-statement/config/chapters/04-associated-incomes/associatedIncomePages.js on lines 83..111
    src/applications/income-and-asset-statement/config/chapters/05-owned-assets/ownedAssetPages.js on lines 88..116
    src/applications/income-and-asset-statement/config/chapters/06-royalties-and-other-properties/royaltiesAndOtherPropertyPages.js on lines 92..121
    src/applications/income-and-asset-statement/config/chapters/07-asset-transfers/assetTransferPages.js on lines 104..132
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 78..105
    src/applications/income-and-asset-statement/config/chapters/10-unreported-assets/unreportedAssetPages.js on lines 80..108
    src/applications/income-and-asset-statement/config/chapters/11-discontinued-incomes/discontinuedIncomePages.js on lines 85..113
    src/applications/income-and-asset-statement/config/chapters/12-income-receipt-waivers/incomeReceiptWaiverPages.js on lines 85..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const addedFundsPage = {
      uiSchema: {
        ...arrayBuilderItemSubsequentPageTitleUI('Trust'),
        addedFundsDate: currentOrPastDateUI('When did you add funds?'),
        addedFundsAmount: merge({}, currencyUI('How much did you add?'), {
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 230..248

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const trustTypePage = {
      uiSchema: {
        ...arrayBuilderItemSubsequentPageTitleUI('Trust'),
        trustType: radioUI({
          title: 'What is the type of trust established?',
    src/applications/income-and-asset-statement/config/chapters/11-discontinued-incomes/discontinuedIncomePages.js on lines 208..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      trustAddedFundsPage: pageBuilder.itemPage({
        title: 'Trust added funds',
        path: 'trusts/:index/added-funds',
        depends: (formData, index) =>
          formData?.[options.arrayPath]?.[index]?.addedFundsAfterEstablishment,
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 287..294

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    const controlPage = {
      uiSchema: {
        ...arrayBuilderItemSubsequentPageTitleUI('Trust'),
        haveAuthorityOrControlOfTrust: yesNoUI(
          'Do you have any additional authority or control of the trust?',
    src/applications/income-and-asset-statement/config/chapters/07-asset-transfers/assetTransferPages.js on lines 234..246
    src/applications/income-and-asset-statement/config/chapters/07-asset-transfers/assetTransferPages.js on lines 249..265
    src/applications/income-and-asset-statement/config/chapters/08-trusts/trustPages.js on lines 222..236
    src/applications/income-and-asset-statement/config/chapters/08-trusts/trustPages.js on lines 256..270
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 213..227
    src/applications/income-and-asset-statement/config/chapters/11-discontinued-incomes/discontinuedIncomePages.js on lines 226..240
    src/applications/pensions/config/chapters/05-financial-information/careExpensesPages.js on lines 133..145

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    const veteransChildPage = {
      uiSchema: {
        ...arrayBuilderItemSubsequentPageTitleUI('Trust'),
        trustEstablishedForVeteransChild: yesNoUI(
          'Was the trust established for a child of the Veteran who was incapable of self-support prior to reaching age 18?',
    src/applications/income-and-asset-statement/config/chapters/07-asset-transfers/assetTransferPages.js on lines 234..246
    src/applications/income-and-asset-statement/config/chapters/07-asset-transfers/assetTransferPages.js on lines 249..265
    src/applications/income-and-asset-statement/config/chapters/08-trusts/trustPages.js on lines 239..253
    src/applications/income-and-asset-statement/config/chapters/08-trusts/trustPages.js on lines 256..270
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 213..227
    src/applications/income-and-asset-statement/config/chapters/11-discontinued-incomes/discontinuedIncomePages.js on lines 226..240
    src/applications/pensions/config/chapters/05-financial-information/careExpensesPages.js on lines 133..145

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    const hasAddedFundsPage = {
      uiSchema: {
        ...arrayBuilderItemSubsequentPageTitleUI('Trust'),
        addedFundsAfterEstablishment: yesNoUI(
          'Have you added funds to the trust after it was established?',
    src/applications/income-and-asset-statement/config/chapters/07-asset-transfers/assetTransferPages.js on lines 234..246
    src/applications/income-and-asset-statement/config/chapters/07-asset-transfers/assetTransferPages.js on lines 249..265
    src/applications/income-and-asset-statement/config/chapters/08-trusts/trustPages.js on lines 222..236
    src/applications/income-and-asset-statement/config/chapters/08-trusts/trustPages.js on lines 239..253
    src/applications/income-and-asset-statement/config/chapters/09-annuities/annuityPages.js on lines 213..227
    src/applications/income-and-asset-statement/config/chapters/11-discontinued-incomes/discontinuedIncomePages.js on lines 226..240
    src/applications/pensions/config/chapters/05-financial-information/careExpensesPages.js on lines 133..145

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status