department-of-veterans-affairs/vets-website

View on GitHub
src/applications/ivc-champva/10-10D/components/Applicant/applicantFileUpload.js

Summary

Maintainability
F
3 days
Test Coverage

File applicantFileUpload.js has 535 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import { titleUI } from 'platform/forms-system/src/js/web-component-patterns';
import { fileUploadBlurbCustom } from 'applications/ivc-champva/shared/components/fileUploads/attachments';
import { applicantWording } from '../../../shared/utilities';
import ApplicantField from '../../../shared/components/applicantLists/ApplicantField';

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export const applicantMedicarePartDCardsUploadUiSchema = {
      applicants: {
        'ui:options': { viewField: ApplicantField },
        items: {
          ...titleUI(
    src/applications/ivc-champva/10-10D/components/Applicant/applicantFileUpload.js on lines 268..299

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 172.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export const applicantMedicarePartAPartBCardsUploadUiSchema = {
      applicants: {
        'ui:options': { viewField: ApplicantField },
        items: {
          ...titleUI(
    src/applications/ivc-champva/10-10D/components/Applicant/applicantFileUpload.js on lines 306..337

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 172.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

        <ul>
          <li>
            Marriage certificate, <b>or</b>
          </li>
          <li>
    src/applications/combined-debt-portal/debt-letters/components/NeedHelp.jsx on lines 17..26
    src/applications/hca/components/IntroductionPage/GetStarted/ProcessTimeline.jsx on lines 34..46
    src/applications/ivc-champva/10-10D/components/Applicant/applicantFileUpload.js on lines 49..57
    src/applications/ivc-champva/10-7959C/chapters/medicareInformation.js on lines 228..236
    src/applications/pensions/components/FormAlerts/index.jsx on lines 61..70
    src/applications/static-pages/health-care-manage-benefits/schedule-view-va-appointments-page/components/AuthContent/index.js on lines 78..87
    src/applications/static-pages/health-care-manage-benefits/schedule-view-va-appointments-page/components/UnauthContent/index.js on lines 49..58
    src/applications/veteran-id-card/containers/Main.jsx on lines 107..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

        <ul>
          <li>
            Divorce decree, <b>or</b>
          </li>
          <li>
    src/applications/combined-debt-portal/debt-letters/components/NeedHelp.jsx on lines 17..26
    src/applications/hca/components/IntroductionPage/GetStarted/ProcessTimeline.jsx on lines 34..46
    src/applications/ivc-champva/10-10D/components/Applicant/applicantFileUpload.js on lines 34..42
    src/applications/ivc-champva/10-7959C/chapters/medicareInformation.js on lines 228..236
    src/applications/pensions/components/FormAlerts/index.jsx on lines 61..70
    src/applications/static-pages/health-care-manage-benefits/schedule-view-va-appointments-page/components/AuthContent/index.js on lines 78..87
    src/applications/static-pages/health-care-manage-benefits/schedule-view-va-appointments-page/components/UnauthContent/index.js on lines 49..58
    src/applications/veteran-id-card/containers/Main.jsx on lines 107..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function isRequiredFile(formContext) {
      return Object.keys(formContext?.schema?.properties || {}).filter(v =>
        Object.keys(REQUIRED_FILES).includes(v),
      ).length >= 1
        ? '(Required)'
    src/applications/ivc-champva/10-7959C/helpers/utilities.js on lines 4..10

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

                  <ul>
                    <li>
                      Divorce decree, <b>or</b>
                    </li>
                    <li>
    src/applications/gi/containers/search/LocationSearchResults.jsx on lines 601..609
    src/applications/hca/components/FormDescriptions/HealthEnrollmentDescription.jsx on lines 34..46
    src/applications/hca/components/IntroductionPage/GetStarted/ProcessTimeline.jsx on lines 83..94
    src/applications/ivc-champva/10-10D/containers/IntroductionPage.jsx on lines 65..74
    src/applications/ivc-champva/10-7959C/containers/IntroductionPage.jsx on lines 37..50
    src/applications/ivc-champva/10-7959f-2/components/PaymentSelection.jsx on lines 10..21
    src/applications/mhv-secure-messaging/components/Alerts/CernerTransitioningFacilityAlert.jsx on lines 69..79
    src/applications/static-pages/health-care-manage-benefits/refill-track-prescriptions-page/components/AuthContent/index.js on lines 170..177
    src/applications/static-pages/health-care-manage-benefits/view-test-and-lab-results-page/components/AuthContent/index.js on lines 184..196
    src/applications/static-pages/health-care-manage-benefits/view-test-and-lab-results-page/components/UnauthContent/index.js on lines 79..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status