department-of-veterans-affairs/vets-website

View on GitHub
src/applications/mhv-medical-records/util/helpers.js

Summary

Maintainability
D
2 days
Test Coverage

File helpers.js has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import moment from 'moment-timezone';
import * as Sentry from '@sentry/browser';
import { snakeCase } from 'lodash';
import { generatePdf } from '@department-of-veterans-affairs/platform-pdf/exports';
import { formatDateLong } from '@department-of-veterans-affairs/platform-utilities/exports';
Severity: Minor
Found in src/applications/mhv-medical-records/util/helpers.js - About 2 hrs to fix

    Function dateFormatWithoutTimezone has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export const dateFormatWithoutTimezone = datetime => {
      let withoutTimezone = datetime;
      if (typeof datetime === 'string' && datetime.includes('-')) {
        // Check if datetime has a timezone and strip it off if present
        if (datetime.includes('T')) {
    Severity: Minor
    Found in src/applications/mhv-medical-records/util/helpers.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return refreshPhases.FAILED;
    Severity: Major
    Found in src/applications/mhv-medical-records/util/helpers.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return refreshPhases.CURRENT;
      Severity: Major
      Found in src/applications/mhv-medical-records/util/helpers.js - About 30 mins to fix

        Function getLastUpdatedText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export const getLastUpdatedText = (refreshStateStatus, extractType) => {
          if (refreshStateStatus) {
            const extract = refreshStateStatus.find(
              status => status.extract === extractType,
            );
        Severity: Minor
        Found in src/applications/mhv-medical-records/util/helpers.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const generateTextFile = (content, fileName) => {
          const blob = new Blob([content], { type: 'text/plain' });
          const url = window.URL.createObjectURL(blob);
          const a = document.createElement('a');
          a.href = url;
        Severity: Major
        Found in src/applications/mhv-medical-records/util/helpers.js and 1 other location - About 4 hrs to fix
        src/applications/mhv-medications/util/helpers.js on lines 78..87

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const getReactions = record => {
          const reactions = [];
          if (!record || !record.reaction) return reactions;
          record.reaction.forEach(reaction => {
            reaction.manifestation.forEach(manifestation => {
        Severity: Major
        Found in src/applications/mhv-medical-records/util/helpers.js and 1 other location - About 3 hrs to fix
        src/applications/mhv-medications/util/helpers.js on lines 113..122

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const extractContainedResource = (resource, referenceId) => {
          if (resource && isArrayAndHasItems(resource.contained) && referenceId) {
            // Strip the leading "#" from the reference.
            const strippedRefId = referenceId.substring(1);
            const containedResource = resource.contained.find(
        Severity: Major
        Found in src/applications/mhv-medical-records/util/helpers.js and 1 other location - About 3 hrs to fix
        src/applications/mhv-medications/util/helpers.js on lines 130..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const processList = list => {
          if (Array.isArray(list)) {
            if (list?.length > 1) return list.join('. ');
            if (list?.length === 1) return list.toString();
          }
        Severity: Major
        Found in src/applications/mhv-medical-records/util/helpers.js and 1 other location - About 2 hrs to fix
        src/applications/mhv-medications/util/helpers.js on lines 93..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status