Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/mhv-medical-records/util/pdfHelpers/demographics.js

Summary

Maintainability
F
1 wk
Test Coverage

Function generateDemographicsContent has 409 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const generateDemographicsContent = record => {
  const results = {
    results: {
      sectionSeparators: false,
      items: [
Severity: Major
Found in src/applications/mhv-medical-records/util/pdfHelpers/demographics.js - About 2 days to fix

    File demographics.js has 412 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { NO_INFO_REPORTED, NONE_RECORDED } from '../constants';

export const generateDemographicsContent = record => {
  const results = {
    results: {
    Severity: Minor
    Found in src/applications/mhv-medical-records/util/pdfHelpers/demographics.js - About 5 hrs to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              {
          header: 'Civil guardian',
          headerIndent: 40,
          headerType: 'H4',
          itemsIndent: 40,
      Severity: Major
      Found in src/applications/mhv-medical-records/util/pdfHelpers/demographics.js and 3 other locations - About 1 day to fix
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 171..214
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 215..258
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 259..302

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 224.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              {
          header: 'Primary next of kin',
          headerIndent: 40,
          headerType: 'H4',
          itemsIndent: 40,
      Severity: Major
      Found in src/applications/mhv-medical-records/util/pdfHelpers/demographics.js and 3 other locations - About 1 day to fix
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 215..258
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 259..302
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 303..346

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 224.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              {
          header: 'Emergency contact',
          headerIndent: 40,
          headerType: 'H4',
          itemsIndent: 40,
      Severity: Major
      Found in src/applications/mhv-medical-records/util/pdfHelpers/demographics.js and 3 other locations - About 1 day to fix
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 171..214
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 259..302
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 303..346

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 224.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              {
          header: 'VA guardian',
          headerIndent: 40,
          headerType: 'H4',
          itemsIndent: 40,
      Severity: Major
      Found in src/applications/mhv-medical-records/util/pdfHelpers/demographics.js and 3 other locations - About 1 day to fix
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 171..214
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 215..258
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 303..346

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 224.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
          header: 'Employment',
          headerIndent: 40,
          headerType: 'H4',
          itemsIndent: 40,
      Severity: Major
      Found in src/applications/mhv-medical-records/util/pdfHelpers/demographics.js and 1 other location - About 3 hrs to fix
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 123..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
          header: 'Eligibility',
          headerIndent: 40,
          headerType: 'H4',
          itemsIndent: 40,
      Severity: Major
      Found in src/applications/mhv-medical-records/util/pdfHelpers/demographics.js and 1 other location - About 3 hrs to fix
      src/applications/mhv-medical-records/util/pdfHelpers/demographics.js on lines 147..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status