Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/mhv-medications/util/pdfConfigs.js

Summary

Maintainability
F
4 days
Test Coverage

Function buildVAPrescriptionPDFList has 184 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const buildVAPrescriptionPDFList = prescription => {
  const refillHistory = [...(prescription?.rxRfRecords || [])];
  const originalFill = createOriginalFillRecord(prescription);
  refillHistory.push(originalFill);
Severity: Major
Found in src/applications/mhv-medications/util/pdfConfigs.js - About 7 hrs to fix

    File pdfConfigs.js has 450 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  createNoDescriptionText,
  createOriginalFillRecord,
  dateFormat,
  processList,
    Severity: Minor
    Found in src/applications/mhv-medications/util/pdfConfigs.js - About 6 hrs to fix

      Function buildPrescriptionsPDFList has 92 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const buildPrescriptionsPDFList = prescriptions => {
  return prescriptions?.map(rx => {
    if (rx?.prescriptionSource === 'NV') {
      return {
        ...buildNonVAPrescriptionPDFList(rx)[0],
      Severity: Major
      Found in src/applications/mhv-medications/util/pdfConfigs.js - About 3 hrs to fix

        Function items has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    .map((entry, i) => {
              const { shape, color, backImprint, frontImprint } = entry;
              const index = refillHistory.length - i - 1;
              const phone =
                entry.cmopDivisionPhone || entry.dialCmopDivisionPhone;
        Severity: Major
        Found in src/applications/mhv-medications/util/pdfConfigs.js - About 2 hrs to fix

          Function buildNonVAPrescriptionPDFList has 63 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export const buildNonVAPrescriptionPDFList = prescription => {
  return [
    {
      sections: [
        {
          Severity: Major
          Found in src/applications/mhv-medications/util/pdfConfigs.js - About 2 hrs to fix

            Function buildVAPrescriptionPDFList has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

            export const buildVAPrescriptionPDFList = prescription => {
  const refillHistory = [...(prescription?.rxRfRecords || [])];
  const originalFill = createOriginalFillRecord(prescription);
  refillHistory.push(originalFill);
            Severity: Minor
            Found in src/applications/mhv-medications/util/pdfConfigs.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function buildMedicationInformationPDF has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export const buildMedicationInformationPDF = list => {
  const listOfHeaders = ['h2', 'h3'];
  const sections = [
    ...list
      .filter(listItem => listOfHeaders.includes(listItem.type))
            Severity: Minor
            Found in src/applications/mhv-medications/util/pdfConfigs.js - About 1 hr to fix

              Function buildAllergiesPDFList has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export const buildAllergiesPDFList = allergies => {
  return allergies.map(item => {
    return {
      header: item.name,
      sections: [
              Severity: Minor
              Found in src/applications/mhv-medications/util/pdfConfigs.js - About 1 hr to fix

                Function sections has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      .map(listItem => {
        const object = { header: '', headerSize: 'H2', items: [] };
        object.header = listItem.text;
        const index = list.indexOf(listItem);
        const nextHeader = list
                Severity: Minor
                Found in src/applications/mhv-medications/util/pdfConfigs.js - About 1 hr to fix

                  Function buildMedicationInformationPDF has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export const buildMedicationInformationPDF = list => {
  const listOfHeaders = ['h2', 'h3'];
  const sections = [
    ...list
      .filter(listItem => listOfHeaders.includes(listItem.type))
                  Severity: Minor
                  Found in src/applications/mhv-medications/util/pdfConfigs.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function buildPrescriptionsPDFList has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export const buildPrescriptionsPDFList = prescriptions => {
  return prescriptions?.map(rx => {
    if (rx?.prescriptionSource === 'NV') {
      return {
        ...buildNonVAPrescriptionPDFList(rx)[0],
                  Severity: Minor
                  Found in src/applications/mhv-medications/util/pdfConfigs.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            items: [
            {
              title: 'Instructions',
              value: validateField(rx.sig),
              inline: true,
                  Severity: Major
                  Found in src/applications/mhv-medications/util/pdfConfigs.js and 1 other location - About 2 hrs to fix
                  src/applications/mhv-medications/util/pdfConfigs.js on lines 407..423

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 81.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            items: [
            {
              title: 'Instructions',
              value: validateField(prescription.sig),
              inline: true,
                  Severity: Major
                  Found in src/applications/mhv-medications/util/pdfConfigs.js and 1 other location - About 2 hrs to fix
                  src/applications/mhv-medications/util/pdfConfigs.js on lines 194..210

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 81.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              {
              title: 'Documented by',
              value: prescription.providerLastName
                ? `${
                    prescription.providerLastName
                  Severity: Minor
                  Found in src/applications/mhv-medications/util/pdfConfigs.js and 1 other location - About 50 mins to fix
                  src/applications/mhv-medications/util/pdfConfigs.js on lines 379..387

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              {
              title: 'Prescribed by',
              value: prescription.providerLastName
                ? `${
                    prescription.providerLastName
                  Severity: Minor
                  Found in src/applications/mhv-medications/util/pdfConfigs.js and 1 other location - About 50 mins to fix
                  src/applications/mhv-medications/util/pdfConfigs.js on lines 85..93

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status