Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/mhv-secure-messaging/api/SmApi.js

Summary

Maintainability
C
1 day
Test Coverage

File SmApi.js has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import environment from '@department-of-veterans-affairs/platform-utilities/environment';
import { apiRequest } from '@department-of-veterans-affairs/platform-utilities/exports';
import { DefaultFolders, threadSortingOptions } from '../util/constants';

const apiBasePath = `${environment.API_URL}/my_health/v1`;
Severity: Minor
Found in src/applications/mhv-secure-messaging/api/SmApi.js - About 2 hrs to fix

    Function getThreadList has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const getThreadList = async params => {
  const {
    folderId = 0,
    pageSize = 10,
    pageNumber = 1,
    Severity: Minor
    Found in src/applications/mhv-secure-messaging/api/SmApi.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const createFolder = folderName => {
  return apiRequest(`${apiBasePath}/messaging/folders`, {
    method: 'POST',
    headers: {
      'Content-Type': 'application/json',
      Severity: Major
      Found in src/applications/mhv-secure-messaging/api/SmApi.js and 1 other location - About 1 hr to fix
      src/applications/mhv-secure-messaging/api/SmApi.js on lines 370..378

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const updatePreferredRecipients = updatedTriageTeams => {
  return apiRequest(`${apiBasePath}/messaging/preferences/recipients`, {
    method: 'POST',
    headers: {
      'Content-Type': 'application/json',
      Severity: Major
      Found in src/applications/mhv-secure-messaging/api/SmApi.js and 1 other location - About 1 hr to fix
      src/applications/mhv-secure-messaging/api/SmApi.js on lines 46..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const updateDraft = (draftMessageId, message) => {
  return apiRequest(
    `${apiBasePath}/messaging/message_drafts/${draftMessageId}`,
    {
      method: 'PUT',
      Severity: Major
      Found in src/applications/mhv-secure-messaging/api/SmApi.js and 1 other location - About 1 hr to fix
      src/applications/mhv-secure-messaging/api/SmApi.js on lines 153..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const createReplyDraft = (replyToId, message) => {
  return apiRequest(
    `${apiBasePath}/messaging/message_drafts/${replyToId}/replydraft`,
    {
      method: 'POST',
      Severity: Major
      Found in src/applications/mhv-secure-messaging/api/SmApi.js and 1 other location - About 1 hr to fix
      src/applications/mhv-secure-messaging/api/SmApi.js on lines 134..145

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const getMessage = messageId => {
  return apiRequest(`${apiBasePath}/messaging/messages/${messageId}`, {
    headers: {
      'Content-Type': 'application/json',
    },
      Severity: Minor
      Found in src/applications/mhv-secure-messaging/api/SmApi.js and 1 other location - About 35 mins to fix
      src/applications/avs/api/v0.js on lines 12..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const getSignature = () => {
  return apiRequest(`${apiBasePath}/messaging/messages/signature`, {
    headers: {
      'Content-Type': 'application/json',
      Accept: 'application/json',
      Severity: Minor
      Found in src/applications/mhv-secure-messaging/api/SmApi.js and 1 other location - About 35 mins to fix
      src/applications/mhv-secure-messaging/api/SmApi.js on lines 90..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const getMessageCategoryList = () => {
  return apiRequest(`${apiBasePath}/messaging/messages/categories`, {
    headers: {
      'Content-Type': 'application/json',
      Accept: 'application/json',
      Severity: Minor
      Found in src/applications/mhv-secure-messaging/api/SmApi.js and 1 other location - About 35 mins to fix
      src/applications/mhv-secure-messaging/api/SmApi.js on lines 406..413

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status