Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/mhv-secure-messaging/api/mocks/folders/index.js

Summary

Maintainability
B
5 hrs
Test Coverage

Similar blocks of code found in 16 locations. Consider refactoring.
Open

    {
      id: '2708575',
      type: 'message_threads',
      attributes: {
        threadId: 2708575,
Severity: Major
Found in src/applications/mhv-secure-messaging/api/mocks/folders/index.js and 15 other locations - About 4 hrs to fix
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 113..139
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 140..166
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 167..193
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 194..220
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 221..247
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 248..274
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 275..301
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 302..328
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 329..355
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 356..382
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 383..409
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 410..436
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 437..463
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 464..490
src/platform/mhv/api/mocks/secure-messaging/threads/inboxThreads.js on lines 491..517

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

const oneFolder = {
  data: {
    id: '0',
    type: 'folders',
    attributes: {
Severity: Major
Found in src/applications/mhv-secure-messaging/api/mocks/folders/index.js and 6 other locations - About 1 hr to fix
src/applications/mhv-landing-page/mocks/api/mhv-api/messaging/folders/index.js on lines 53..68
src/applications/mhv-landing-page/mocks/api/mhv-api/messaging/folders/index.js on lines 70..85
src/applications/mhv-medications/mocks/api/mhv-api/messaging/folders/index.js on lines 53..68
src/applications/mhv-medications/mocks/api/mhv-api/messaging/folders/index.js on lines 70..85
src/platform/mhv/downtime/mocks/api/mhv-api/messaging/folders/index.js on lines 53..68
src/platform/mhv/downtime/mocks/api/mhv-api/messaging/folders/index.js on lines 70..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status