Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js

Summary

Maintainability
C
1 day
Test Coverage

File contactMethod.js has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import { createSelector } from 'reselect';

import TextNotificationsDisclaimer from '../../../../components/TextNotificationsDisclaimer';
import { formFields } from '../../../../constants';
Severity: Minor
Found in src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js - About 3 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          'ui:description': (
        <va-alert status="warning">
          <>
            You can’t choose to get email notifications because your email is on
            file for another person with education benefits. You will not be
    Severity: Major
    Found in src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js and 3 other locations - About 1 hr to fix
    src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js on lines 217..236
    src/applications/toe/config/form.js on lines 1000..1020
    src/applications/toe/config/form.js on lines 1040..1060

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          'ui:description': (
        <va-alert status="warning">
          <>
            You can’t choose to get text notifications because your mobile phone
            number is on file for another person with education benefits. You
    Severity: Major
    Found in src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js and 3 other locations - About 1 hr to fix
    src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js on lines 183..202
    src/applications/toe/config/form.js on lines 1000..1020
    src/applications/toe/config/form.js on lines 1040..1060

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            'ui:options': {
          widgetProps: {
            Yes: { 'data-info': 'yes' },
            No: { 'data-info': 'no' },
          },
    Severity: Major
    Found in src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js and 1 other location - About 1 hr to fix
    src/applications/fry-dea/config/form.js on lines 1098..1107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            <va-alert status="info">
          <>
            If you choose to get text message notifications from VA’s GI Bill
            program, message and data rates may apply. Students will receive an
            average of two messages per month. At this time, we can only send
    Severity: Major
    Found in src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js and 1 other location - About 1 hr to fix
    src/applications/fry-dea/config/form.js on lines 1053..1068

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          [formFields.viewReceiveTextMessages]: {
        type: 'object',
        required: [formFields.receiveTextMessages],
        properties: {
          [formFields.receiveTextMessages]: {
    Severity: Major
    Found in src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js and 1 other location - About 1 hr to fix
    src/applications/fry-dea/config/form.js on lines 1179..1191

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if (isYes) {
              if (!phoneExist) {
                errors.addError(
                  "You can't select that response because we don't have a mobile phone number on file for you.",
                );
    Severity: Minor
    Found in src/applications/my-education-benefits/config/chapters/33/contactInfo/contactMethod.js and 1 other location - About 35 mins to fix
    src/applications/toe/config/form.js on lines 953..963

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status