Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/my-education-benefits/utils/form-submit-transform.js

Summary

Maintainability
D
2 days
Test Coverage

File form-submit-transform.js has 517 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// this constant maps the values on address.js in vets.json schema from VA.gov values to LTS values

import { formFields } from '../constants';

// the lts values were found on the LTS database and LTS validates them, so we need to send correct value from here
Severity: Major
Found in src/applications/my-education-benefits/utils/form-submit-transform.js - About 1 day to fix

    Function createAdditionalConsiderations has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function createAdditionalConsiderations(submissionForm) {
  if (submissionForm?.mebExclusionPeriodEnabled) {
    const exclusionPeriods = submissionForm.exclusionPeriods || [];
    const mapping = {
      academyRotcScholarship: {
    Severity: Major
    Found in src/applications/my-education-benefits/utils/form-submit-transform.js - About 2 hrs to fix

      Function createMilitaryClaimant has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function createMilitaryClaimant(submissionForm) {
  // Access formField and viewComponent sources for userFullName and dateOfBirth
  const formFieldUserFullName =
    submissionForm['view:userFullName']?.userFullName;
  const viewComponentUserFullName = submissionForm?.userFullName;
      Severity: Minor
      Found in src/applications/my-education-benefits/utils/form-submit-transform.js - About 1 hr to fix

        Function createDirectDeposit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export function createDirectDeposit(submissionForm) {
  const bankAccountInView = submissionForm['view:directDeposit']?.bankAccount;
  const bankAccountDirectly = submissionForm?.bankAccount;

  const hasDataInView =
        Severity: Minor
        Found in src/applications/my-education-benefits/utils/form-submit-transform.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createComments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export function createComments(submissionForm) {
  if (submissionForm['view:serviceHistory'].serviceHistoryIncorrect) {
    if (submissionForm.incorrectServiceHistoryExplanation) {
      return {
        claimantComment: {
        Severity: Minor
        Found in src/applications/my-education-benefits/utils/form-submit-transform.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

        export function getSchemaCountryCode(inputSchemaValue) {
  // Check if inputSchemaValue is undefined or not a string, and return the default value right away.
  if (typeof inputSchemaValue !== 'string') {
    return DEFAULT_SCHEMA_COUNTRY_CODE;
  }
        Severity: Major
        Found in src/applications/my-education-benefits/utils/form-submit-transform.js and 2 other locations - About 4 hrs to fix
        src/applications/survivor-dependent-education-benefit/22-5490/utils/form-submit-transform.js on lines 255..274
        src/applications/toe/utils/form-submit-transform.js on lines 255..274

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 134.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        export function getLTSCountryCode(schemaCountryValue) {
  // Start by assuming the input is a three-character code.
  let country = countries.find(
    countryInfo => countryInfo.schemaValue === schemaCountryValue,
  );
        Severity: Major
        Found in src/applications/my-education-benefits/utils/form-submit-transform.js and 1 other location - About 4 hrs to fix
        src/applications/toe/utils/form-submit-transform.js on lines 276..289

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status