Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/pensions/config/chapters/03-health-and-employment-information/helpers.js

Summary

Maintainability
C
1 day
Test Coverage

File helpers.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import PropTypes from 'prop-types';
import { VaTextInputField } from 'platform/forms-system/src/js/web-component-fields';
import {
  currentOrPastDateUI,
Severity: Minor
Found in src/applications/pensions/config/chapters/03-health-and-employment-information/helpers.js - About 2 hrs to fix

    Function generateMedicalCentersSchemas has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const generateMedicalCentersSchemas = (
  medicalCentersKey = 'medicalCenters',
  medicalCentersTitle = 'Default Medical Centers Title',
  medicalCenterMessage = 'Default Message',
  medicalCenterFieldLabel = 'Default Field Label',
    Severity: Minor
    Found in src/applications/pensions/config/chapters/03-health-and-employment-information/helpers.js - About 1 hr to fix

      Function MedicalConditionDescription has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function MedicalConditionDescription() {
  return (
    <div>
      <p>
        We need to know about any medical conditions that prevent you from
      Severity: Minor
      Found in src/applications/pensions/config/chapters/03-health-and-employment-information/helpers.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <div>
          <p>
            If your medical condition prevents you from working, both of these
            must be true:
          </p>
        Severity: Major
        Found in src/applications/pensions/config/chapters/03-health-and-employment-information/helpers.js and 1 other location - About 1 hr to fix
        src/applications/pensions/config/chapters/06-additional-information/supportingDocuments.js on lines 149..157

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export function MedicalEvidenceNotice() {
  return (
    <div>
      <p>
        Based on your answer, you’ll need to submit additional evidence about
        Severity: Minor
        Found in src/applications/pensions/config/chapters/03-health-and-employment-information/helpers.js and 1 other location - About 50 mins to fix
        src/applications/pensions/config/chapters/05-financial-information/helpers.js on lines 19..32

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status