Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/personalization/profile/mocks/endpoints/communication-preferences/index.js

Summary

Maintainability
F
3 days
Test Coverage

File index.js has 256 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const maximalSetOfPreferences = {
  data: {
    id: '',
    type: 'hashes',
    attributes: {
Severity: Minor
Found in src/applications/personalization/profile/mocks/endpoints/communication-preferences/index.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            {
          id: 3,
          name: 'Your health care',
          description: null,
          communicationItems: [
    Severity: Major
    Found in src/applications/personalization/profile/mocks/endpoints/communication-preferences/index.js and 1 other location - About 2 days to fix
    src/applications/representative-appoint/mocks/endpoints/communication-preferences/index.js on lines 54..169

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 389.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            {
          id: 1,
          name: 'Applications, claims, decision reviews, and appeals',
          description: null,
          communicationItems: [
    Severity: Major
    Found in src/applications/personalization/profile/mocks/endpoints/communication-preferences/index.js and 1 other location - About 2 hrs to fix
    src/applications/representative-appoint/mocks/endpoints/communication-preferences/index.js on lines 25..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const generateSuccess = () => ({
  txAuditId: 'a9987d62-28f8-4b02-b020-b7f17c13c124',
  status: 'COMPLETED_SUCCESS',
  bio: {
    createDate: '2023-01-05T20:05:25Z',
    Severity: Major
    Found in src/applications/personalization/profile/mocks/endpoints/communication-preferences/index.js and 1 other location - About 2 hrs to fix
    src/applications/representative-appoint/mocks/endpoints/communication-preferences/index.js on lines 216..233

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            {
          id: 2,
          name: 'General VA Updates and Information',
          description: null,
          communicationItems: [
    Severity: Major
    Found in src/applications/personalization/profile/mocks/endpoints/communication-preferences/index.js and 1 other location - About 1 hr to fix
    src/applications/representative-appoint/mocks/endpoints/communication-preferences/index.js on lines 170..191

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            {
          id: 5,
          name: 'QuickSubmit',
          description: 'QuickSubmit Notifications',
          communicationItems: [
    Severity: Major
    Found in src/applications/personalization/profile/mocks/endpoints/communication-preferences/index.js and 1 other location - About 1 hr to fix
    src/applications/representative-appoint/mocks/endpoints/communication-preferences/index.js on lines 192..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status