Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/personalization/profile/reducers/directDeposit.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function directDeposit has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function directDeposit(state = initialState, action) {
  switch (action.type) {
    case DIRECT_DEPOSIT_FETCH_SUCCEEDED:
    case DIRECT_DEPOSIT_SAVE_SUCCEEDED: {
      return {
Severity: Major
Found in src/applications/personalization/profile/reducers/directDeposit.js - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

          return {
        ...state,
        saveError: action.response?.error ?? action.response?.errors ?? true,
        ui: {
          ...state.ui,
    Severity: Major
    Found in src/applications/personalization/profile/reducers/directDeposit.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return {
        ...state,
        loadError: null,
      };
      Severity: Major
      Found in src/applications/personalization/profile/reducers/directDeposit.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return {
        ...state,
        saveError: null,
        ui: {
          ...state.ui,
        Severity: Major
        Found in src/applications/personalization/profile/reducers/directDeposit.js - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status