Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/public-outreach-materials/libraries/library-filters.js

Summary

Maintainability
D
2 days
Test Coverage

Function libraryFilters has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function libraryFilters(el) {
  // Grab our current page from the active pager button.
  if (el.srcElement.classList.contains('pager-numbers')) {
    activePage = parseInt(el.srcElement.text, 10);
    sessionStorage.setItem('pageNum', parseInt(el.srcElement.text, 10));
Severity: Major
Found in src/applications/public-outreach-materials/libraries/library-filters.js - About 2 hrs to fix

    Function libraryCount has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    export function libraryCount() {
  if (document.getElementById('no-results')) {
    document.getElementById('no-results').style.display = 'none';
    document.getElementById('va-pager-div').style.display = 'flex';
    document.getElementById('total-pages-div').style.display = 'flex';
    Severity: Minor
    Found in src/applications/public-outreach-materials/libraries/library-filters.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function libraryFilters has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    export function libraryFilters(el) {
  // Grab our current page from the active pager button.
  if (el.srcElement.classList.contains('pager-numbers')) {
    activePage = parseInt(el.srcElement.text, 10);
    sessionStorage.setItem('pageNum', parseInt(el.srcElement.text, 10));
    Severity: Minor
    Found in src/applications/public-outreach-materials/libraries/library-filters.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function libraryPagerGen has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function libraryPagerGen() {
  const numCardsCount = libraryNumActiveCards();
  numCards = libraryNumCards();
  pages = Math.ceil(numCardsCount / itemsPerPage);
  if (document.getElementById('pager-nums-insert')) {
    Severity: Minor
    Found in src/applications/public-outreach-materials/libraries/library-filters.js - About 1 hr to fix

      Function libraryCurrent has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function libraryCurrent() {
  let increment = 1;
  let numVal;
  Array.prototype.slice.call(cards).forEach(element => {
    if (
      Severity: Minor
      Found in src/applications/public-outreach-materials/libraries/library-filters.js - About 1 hr to fix

        Function libraryCount has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function libraryCount() {
  if (document.getElementById('no-results')) {
    document.getElementById('no-results').style.display = 'none';
    document.getElementById('va-pager-div').style.display = 'flex';
    document.getElementById('total-pages-div').style.display = 'flex';
        Severity: Minor
        Found in src/applications/public-outreach-materials/libraries/library-filters.js - About 1 hr to fix

          Function libraryPagerGen has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          export function libraryPagerGen() {
  const numCardsCount = libraryNumActiveCards();
  numCards = libraryNumCards();
  pages = Math.ceil(numCardsCount / itemsPerPage);
  if (document.getElementById('pager-nums-insert')) {
          Severity: Minor
          Found in src/applications/public-outreach-materials/libraries/library-filters.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (numCards.first < 1 && document.getElementById('no-results')) {
      document.getElementById('va-pager-div').style.display = 'none';
      document.getElementById('total-pages-div').style.display = 'none';
      document.getElementById('no-results').style.display = 'block';
    }
          Severity: Major
          Found in src/applications/public-outreach-materials/libraries/library-filters.js and 1 other location - About 1 hr to fix
          src/applications/public-outreach-materials/libraries/library-filters.js on lines 43..47

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            if (document.getElementById('no-results')) {
    document.getElementById('no-results').style.display = 'none';
    document.getElementById('va-pager-div').style.display = 'flex';
    document.getElementById('total-pages-div').style.display = 'flex';
  }
          Severity: Major
          Found in src/applications/public-outreach-materials/libraries/library-filters.js and 1 other location - About 1 hr to fix
          src/applications/public-outreach-materials/libraries/library-filters.js on lines 65..69

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                const srTally =
        numCards.first < 0
          ? 0
          : `${numCards.first} through ${+numCards.first + +numCards.last - 1}`;
          Severity: Major
          Found in src/applications/public-outreach-materials/libraries/library-filters.js and 1 other location - About 1 hr to fix
          src/applications/public-outreach-materials/libraries/library-filters.js on lines 52..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                const tally =
        numCards.first < 0
          ? 0
          : `${numCards.first} - ${+numCards.first + +numCards.last - 1}`;
          Severity: Major
          Found in src/applications/public-outreach-materials/libraries/library-filters.js and 1 other location - About 1 hr to fix
          src/applications/public-outreach-materials/libraries/library-filters.js on lines 56..59

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (diff >= 1) {
      pagerHtml += `<a href="#${activePage + 1}" aria-label="Page ${activePage +
        1}" class="pager-numbers pager-focus-item" aria-label="Load page
      ${activePage + 1}">${activePage + 1}</a>`;
    }
          Severity: Minor
          Found in src/applications/public-outreach-materials/libraries/library-filters.js and 1 other location - About 40 mins to fix
          src/applications/public-outreach-materials/libraries/library-filters.js on lines 122..126

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (diff >= 2) {
      pagerHtml += `<a href="#${activePage + 2}" aria-label="Page ${activePage +
        2}" class="pager-numbers pager-focus-item" aria-label="Load page
      ${activePage + 2}">${activePage + 2}</a>`;
    }
          Severity: Minor
          Found in src/applications/public-outreach-materials/libraries/library-filters.js and 1 other location - About 40 mins to fix
          src/applications/public-outreach-materials/libraries/library-filters.js on lines 115..119

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            Array.prototype.slice.call(pagerClickers).forEach(element => {
    element.addEventListener('click', libraryClickAccessFocus);
  });
          Severity: Minor
          Found in src/applications/public-outreach-materials/libraries/library-filters.js and 1 other location - About 30 mins to fix
          src/applications/public-outreach-materials/libraries/library-filters.js on lines 138..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                Array.prototype.slice.call(pagingAnchors).forEach(element => {
        element.addEventListener('click', libraryAnchorStop);
      });
          Severity: Minor
          Found in src/applications/public-outreach-materials/libraries/library-filters.js and 1 other location - About 30 mins to fix
          src/applications/public-outreach-materials/libraries/library-filters.js on lines 25..27

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status