Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/simple-forms/21-0966/config/form.js

Summary

Maintainability
F
3 days
Test Coverage

File form.js has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import footerContent from 'platform/forms/components/FormFooter';
import environment from '@department-of-veterans-affairs/platform-utilities/environment';
import manifest from '../manifest.json';

import ITFStatusLoadingIndicatorPage from '../components/ITFStatusLoadingIndicatorPage';
Severity: Minor
Found in src/applications/simple-forms/21-0966/config/form.js - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        veteranContactInformationChapter: {
      title: ({ formData }) =>
        veteranContactInformationChapterTitle({ formData }),
      pages: {
        veteranMailingAddress: {
    Severity: Major
    Found in src/applications/simple-forms/21-0966/config/form.js and 1 other location - About 5 hrs to fix
    src/applications/simple-forms/21-0966/config/form.js on lines 242..267

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        survivingDependentContactInformationChapter: {
      title: ({ formData }) =>
        survivingDependentContactInformationChapterTitle({ formData }),
      pages: {
        survivingDependentMailingAddress: {
    Severity: Major
    Found in src/applications/simple-forms/21-0966/config/form.js and 1 other location - About 5 hrs to fix
    src/applications/simple-forms/21-0966/config/form.js on lines 329..350

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            veteranBenefitSelectionCompensation: {
          path: 'veteran-benefit-selection-compensation',
          depends: formData =>
            shouldSeeVeteranBenefitSelectionCompensation({ formData }),
          title: formData => benefitSelectionChapterTitle({ formData }),
    Severity: Major
    Found in src/applications/simple-forms/21-0966/config/form.js and 1 other location - About 3 hrs to fix
    src/applications/simple-forms/21-0966/config/form.js on lines 177..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            veteranBenefitSelectionPension: {
          path: 'veteran-benefit-selection-pension',
          depends: formData =>
            shouldSeeVeteranBenefitSelectionPension({ formData }),
          title: formData => benefitSelectionChapterTitle({ formData }),
    Severity: Major
    Found in src/applications/simple-forms/21-0966/config/form.js and 1 other location - About 3 hrs to fix
    src/applications/simple-forms/21-0966/config/form.js on lines 163..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            veteranBenefitSelection: {
          path: 'veteran-benefit-selection',
          depends: formData => shouldSeeVeteranBenefitSelection({ formData }),
          title: formData => benefitSelectionChapterTitle({ formData }),
          uiSchema: veteranBenefitSelection.uiSchema,
    Severity: Major
    Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
    src/applications/simple-forms/21-0966/config/form.js on lines 191..197
    src/applications/simple-forms/21-0966/config/form.js on lines 198..204
    src/applications/simple-forms/21-0966/config/form.js on lines 205..212
    src/applications/simple-forms/21-0966/config/form.js on lines 219..229

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            survivingDependentBenefitSelection: {
          path: 'surviving-dependent-benefit-selection',
          depends: formData => preparerIsSurvivingDependent({ formData }),
          title: formData => benefitSelectionChapterTitle({ formData }),
          uiSchema: survivingDependentBenefitSelection.uiSchema,
    Severity: Major
    Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
    src/applications/simple-forms/21-0966/config/form.js on lines 156..162
    src/applications/simple-forms/21-0966/config/form.js on lines 191..197
    src/applications/simple-forms/21-0966/config/form.js on lines 205..212
    src/applications/simple-forms/21-0966/config/form.js on lines 219..229

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            thirdPartySurvivingDependentBenefitSelection: {
          path: 'third-party-surviving-dependent-benefit-selection',
          depends: formData =>
            preparerIsThirdPartyToASurvivingDependent({ formData }),
          title: formData => benefitSelectionChapterTitle({ formData }),
    Severity: Major
    Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
    src/applications/simple-forms/21-0966/config/form.js on lines 156..162
    src/applications/simple-forms/21-0966/config/form.js on lines 191..197
    src/applications/simple-forms/21-0966/config/form.js on lines 198..204
    src/applications/simple-forms/21-0966/config/form.js on lines 219..229

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            thirdPartyVeteranBenefitSelection: {
          path: 'third-party-veteran-benefit-selection',
          depends: formData => preparerIsThirdPartyToTheVeteran({ formData }),
          title: formData => benefitSelectionChapterTitle({ formData }),
          uiSchema: thirdPartyVeteranBenefitSelection.uiSchema,
    Severity: Major
    Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
    src/applications/simple-forms/21-0966/config/form.js on lines 156..162
    src/applications/simple-forms/21-0966/config/form.js on lines 198..204
    src/applications/simple-forms/21-0966/config/form.js on lines 205..212
    src/applications/simple-forms/21-0966/config/form.js on lines 219..229

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            survivingDependentPersonalInformation: {
          path: 'surviving-dependent-personal-information',
          depends: formData =>
            preparerIsSurvivingDependentOrThirdPartyToSurvivingDependent({
              formData,
    Severity: Major
    Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
    src/applications/simple-forms/21-0966/config/form.js on lines 156..162
    src/applications/simple-forms/21-0966/config/form.js on lines 191..197
    src/applications/simple-forms/21-0966/config/form.js on lines 198..204
    src/applications/simple-forms/21-0966/config/form.js on lines 205..212

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status