department-of-veterans-affairs/vets-website

View on GitHub
src/applications/simple-forms/21-0972/config/helpers.js

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

export const claimantExpectedInformationDescription = ({ formData } = {}) => {
  const claimantIdentificationText = getClaimantIdentificationText(formData);
  return `Now, we’ll ask you about the ${claimantIdentificationText} that you’re signing for.`;
};
Severity: Major
Found in src/applications/simple-forms/21-0972/config/helpers.js and 5 other locations - About 45 mins to fix
src/applications/simple-forms/21-0972/config/helpers.js on lines 38..41
src/applications/simple-forms/21-0972/config/helpers.js on lines 43..46
src/applications/simple-forms/21-0972/config/helpers.js on lines 48..51
src/applications/simple-forms/21-0972/config/helpers.js on lines 53..56
src/applications/simple-forms/21-0972/config/helpers.js on lines 71..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

export const claimantContactInformationTitle = ({ formData } = {}) => {
  const claimantIdentificationText = getClaimantIdentificationText(formData);
  return `${claimantIdentificationText} contact information`;
};
Severity: Major
Found in src/applications/simple-forms/21-0972/config/helpers.js and 5 other locations - About 45 mins to fix
src/applications/simple-forms/21-0972/config/helpers.js on lines 38..41
src/applications/simple-forms/21-0972/config/helpers.js on lines 43..46
src/applications/simple-forms/21-0972/config/helpers.js on lines 48..51
src/applications/simple-forms/21-0972/config/helpers.js on lines 71..74
src/applications/simple-forms/21-0972/config/helpers.js on lines 76..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

export const preparerSigningReasonQuestionTitle = ({ formData } = {}) => {
  const claimantIdentificationText = getClaimantIdentificationText(formData);
  return `Why does the ${claimantIdentificationText} need you to sign for them? You can select more than one.`;
};
Severity: Major
Found in src/applications/simple-forms/21-0972/config/helpers.js and 5 other locations - About 45 mins to fix
src/applications/simple-forms/21-0972/config/helpers.js on lines 38..41
src/applications/simple-forms/21-0972/config/helpers.js on lines 43..46
src/applications/simple-forms/21-0972/config/helpers.js on lines 48..51
src/applications/simple-forms/21-0972/config/helpers.js on lines 53..56
src/applications/simple-forms/21-0972/config/helpers.js on lines 76..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

export const claimantPersonalInformationTitle = ({ formData } = {}) => {
  const claimantIdentificationText = getClaimantIdentificationText(formData);
  return `${claimantIdentificationText} personal information`;
};
Severity: Major
Found in src/applications/simple-forms/21-0972/config/helpers.js and 5 other locations - About 45 mins to fix
src/applications/simple-forms/21-0972/config/helpers.js on lines 43..46
src/applications/simple-forms/21-0972/config/helpers.js on lines 48..51
src/applications/simple-forms/21-0972/config/helpers.js on lines 53..56
src/applications/simple-forms/21-0972/config/helpers.js on lines 71..74
src/applications/simple-forms/21-0972/config/helpers.js on lines 76..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

export const claimantSsnTitle = ({ formData } = {}) => {
  const claimantIdentificationText = getClaimantIdentificationText(formData);
  return `${claimantIdentificationText} identification information`;
};
Severity: Major
Found in src/applications/simple-forms/21-0972/config/helpers.js and 5 other locations - About 45 mins to fix
src/applications/simple-forms/21-0972/config/helpers.js on lines 38..41
src/applications/simple-forms/21-0972/config/helpers.js on lines 48..51
src/applications/simple-forms/21-0972/config/helpers.js on lines 53..56
src/applications/simple-forms/21-0972/config/helpers.js on lines 71..74
src/applications/simple-forms/21-0972/config/helpers.js on lines 76..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

export const claimantAddressTitle = ({ formData } = {}) => {
  const claimantIdentificationText = getClaimantIdentificationText(formData);
  return `${claimantIdentificationText} mailing address`;
};
Severity: Major
Found in src/applications/simple-forms/21-0972/config/helpers.js and 5 other locations - About 45 mins to fix
src/applications/simple-forms/21-0972/config/helpers.js on lines 38..41
src/applications/simple-forms/21-0972/config/helpers.js on lines 43..46
src/applications/simple-forms/21-0972/config/helpers.js on lines 53..56
src/applications/simple-forms/21-0972/config/helpers.js on lines 71..74
src/applications/simple-forms/21-0972/config/helpers.js on lines 76..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status