department-of-veterans-affairs/vets-website

View on GitHub
src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js

Summary

Maintainability
D
2 days
Test Coverage

File index.unit.spec.js has 372 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import MockDate from 'mockdate';
import { expect } from 'chai';
import moment from 'moment';
import { within } from '@testing-library/dom';

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        appointment.attributes = {
          ...appointment.attributes,
          minutesDuration: 30,
          status: 'booked',
          localStartTime: yesterday.format('YYYY-MM-DDTHH:mm:ss.000ZZ'),
    src/applications/vaos/appointment-list/components/BackendAppointmentServiceAlert.unit.spec.js on lines 181..206
    src/applications/vaos/appointment-list/components/BackendAppointmentServiceAlert.unit.spec.js on lines 242..267

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 147.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
          start: testDates().start.format('YYYY-MM-DD'),
          end: testDates().end.format('YYYY-MM-DD'),
          requests: [appointment],
          statuses: ['booked', 'arrived', 'fulfilled', 'cancelled'],
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 217..224
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 266..273
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 308..315
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 379..386

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
          start: testDates().start.format('YYYY-MM-DD'),
          end: testDates().end.format('YYYY-MM-DD'),
          requests: [appointment],
          statuses: ['booked', 'arrived', 'fulfilled', 'cancelled'],
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 131..138
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 217..224
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 308..315
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 379..386

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
          start: testDates().start.format('YYYY-MM-DD'),
          end: testDates().end.format('YYYY-MM-DD'),
          requests: [appointment],
          statuses: ['booked', 'arrived', 'fulfilled', 'cancelled'],
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 131..138
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 217..224
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 266..273
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 379..386

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
          start: testDates().start.format('YYYY-MM-DD'),
          end: testDates().end.format('YYYY-MM-DD'),
          requests: [appointment],
          statuses: ['booked', 'arrived', 'fulfilled', 'cancelled'],
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 131..138
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 217..224
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 266..273
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 308..315

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
          start: testDates().start.format('YYYY-MM-DD'),
          end: testDates().end.format('YYYY-MM-DD'),
          requests: [appointment],
          statuses: ['booked', 'arrived', 'fulfilled', 'cancelled'],
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 131..138
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 266..273
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 308..315
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 379..386

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(
          within(firstCard).getByText(
            new RegExp(`^${pastDate.format('h:mm')}`, 'i'),
          ),
        ).to.exist;
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 336..340

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(
          within(firstCard).getByText(
            new RegExp(`^${pastDate.format('h:mm')}`, 'i'),
          ),
        ).to.exist;
    src/applications/vaos/appointment-list/components/PastAppointmentsList/index.unit.spec.js on lines 236..240

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status