Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js

Summary

Maintainability
F
5 days
Test Coverage

File RequestedAppointmentsListGroup.unit.spec.js has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import moment from 'moment';
import MockDate from 'mockdate';
import { mockFetch } from '@department-of-veterans-affairs/platform-testing/helpers';
import { expect } from 'chai';
Severity: Minor
Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js - About 3 hrs to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        appointment.attributes = {
      comment: 'A message from the patient',
      contact: {
        telecom: [
          { type: 'phone', value: '2125551212' },
    Severity: Major
    Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js and 4 other locations - About 1 day to fix
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 41..91
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 265..315
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 262..312
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 390..440

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 266.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        appointment.attributes = {
      comment: 'A message from the patient',
      contact: {
        telecom: [
          { type: 'phone', value: '2125551212' },
    Severity: Major
    Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js and 4 other locations - About 1 day to fix
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 41..91
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 132..182
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 262..312
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 390..440

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 266.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        appointment.attributes = {
      comment: 'A message from the patient',
      contact: {
        telecom: [
          { type: 'phone', value: '2125551212' },
    Severity: Major
    Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js and 3 other locations - About 1 day to fix
    src/applications/vaos/appointment-list/components/BackendAppointmentServiceAlert.unit.spec.js on lines 298..348
    src/applications/vaos/appointment-list/components/BackendAppointmentServiceAlert.unit.spec.js on lines 390..440
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 166..216

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 264.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
      start: moment()
        .subtract(120, 'days')
        .format('YYYY-MM-DD'),
      end: moment()
    Severity: Major
    Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js and 1 other location - About 2 hrs to fix
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 355..364

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
      start: moment()
        .subtract(120, 'days')
        .format('YYYY-MM-DD'),
      end: moment()
    Severity: Major
    Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js and 1 other location - About 2 hrs to fix
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 227..236

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
      start: moment()
        .subtract(120, 'days')
        .format('YYYY-MM-DD'),
      end: moment()
    Severity: Major
    Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js and 5 other locations - About 2 hrs to fix
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 93..102
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 157..166
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 185..194
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 315..324
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 443..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
      start: moment()
        .subtract(120, 'days')
        .format('YYYY-MM-DD'),
      end: moment()
    Severity: Major
    Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js and 5 other locations - About 2 hrs to fix
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 93..102
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 157..166
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 318..327
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 315..324
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 443..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(
      screen.queryByRole('heading', {
        level: 3,
        name: /You don’t have any/,
      }),
    Severity: Minor
    Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js and 1 other location - About 30 mins to fix
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 344..349

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(
      screen.queryByRole('heading', { level: 2, name: 'Canceled requests' }),
    ).not.to.be.ok;
    Severity: Minor
    Found in src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js and 1 other location - About 30 mins to fix
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 338..340

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status