Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should not display Appointment tasks section if appointment is video', async () => {
    const appointment = {
      start: '2021-09-01T10:00:00Z',
      vaos: {
        apiData: {
Severity: Major
Found in src/applications/vaos/components/AppointmentTasksSection.unit.spec.js and 4 other locations - About 5 hrs to fix
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 83..107
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 108..132
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 158..182
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 200..224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should not display Appointment tasks section if not a past appointment', async () => {
    const appointment = {
      start: '2021-09-01T10:00:00Z',
      vaos: {
        apiData: {
Severity: Major
Found in src/applications/vaos/components/AppointmentTasksSection.unit.spec.js and 4 other locations - About 5 hrs to fix
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 108..132
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 133..157
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 158..182
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 200..224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should not display Appointment tasks section if appointment is cc', async () => {
    const appointment = {
      start: '2021-09-01T10:00:00Z',
      vaos: {
        apiData: {
Severity: Major
Found in src/applications/vaos/components/AppointmentTasksSection.unit.spec.js and 4 other locations - About 5 hrs to fix
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 83..107
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 133..157
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 158..182
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 200..224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should not display file claim link if days remaining are less than 1', async () => {
    const appointment = {
      start: '2021-08-31T10:00:00Z',
      vaos: {
        apiData: {
Severity: Major
Found in src/applications/vaos/components/AppointmentTasksSection.unit.spec.js and 4 other locations - About 5 hrs to fix
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 83..107
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 108..132
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 133..157
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 158..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should not display Appointment tasks section if appointment is phone', async () => {
    const appointment = {
      start: '2021-09-01T10:00:00Z',
      vaos: {
        apiData: {
Severity: Major
Found in src/applications/vaos/components/AppointmentTasksSection.unit.spec.js and 4 other locations - About 5 hrs to fix
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 83..107
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 108..132
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 133..157
src/applications/vaos/components/AppointmentTasksSection.unit.spec.js on lines 200..224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      const appointment = {
        start: startTime,
        vaos: {
          apiData: {
            travelPayClaim: {
Severity: Major
Found in src/applications/vaos/components/AppointmentTasksSection.unit.spec.js and 1 other location - About 2 hrs to fix
src/applications/vaos/components/TravelReimbursementSection.unit.spec.js on lines 20..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status