department-of-veterans-affairs/vets-website

View on GitHub
src/applications/vaos/components/layout/InPersonLayout.unit.spec.js

Summary

Maintainability
F
4 days
Test Coverage

File InPersonLayout.unit.spec.js has 603 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import { expect } from 'chai';
import moment from 'moment';
import {
  createTestStore,
Severity: Major
Found in src/applications/vaos/components/layout/InPersonLayout.unit.spec.js - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it('should display facility phone when clinic phone is missing', async () => {
          // Arrange
          const store = createTestStore(initialState);
          const appointment = {
            location: {
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 191..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 163.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it('should display display VA main phone when facility id is missing', async () => {
          // Arrange
          const store = createTestStore(initialState);
          const appointment = {
            location: {},
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 223..251

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          const appointment = {
            reasonForAppointment: 'This is a test',
            patientComments: 'Additional information:colon',
            location: {
              stationId: '983',
    src/applications/vaos/components/layout/PhoneLayout.unit.spec.js on lines 406..428

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          const appointment = {
            reasonForAppointment: 'This is a test',
            patientComments: 'Additional information:colon',
            location: {
              stationId: '983',
    src/applications/vaos/components/layout/PhoneLayout.unit.spec.js on lines 501..520

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 9 locations. Consider refactoring.
    Open

      const initialState = {
        appointments: {
          facilityData: {
            '983': {
              address: {
    src/applications/vaos/components/VideoLink.unit.spec.js on lines 22..42
    src/applications/vaos/components/layout/CCRequestLayout.unit.spec.js on lines 10..30
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 11..31
    src/applications/vaos/components/layout/PhoneLayout.unit.spec.js on lines 11..31
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 10..30
    src/applications/vaos/components/layout/VideoLayout.unit.spec.js on lines 11..31
    src/applications/vaos/components/layout/VideoLayoutAtlas.unit.spec.js on lines 11..31
    src/applications/vaos/components/layout/VideoLayoutVA.unit.spec.js on lines 11..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

          expect(
            screen.getByText((content, element) => {
              return (
                element.tagName.toLowerCase() === 'span' &&
                content === 'Location: Not available'
    src/applications/vaos/components/layout/CCLayout.unit.spec.js on lines 59..66
    src/applications/vaos/components/layout/CCRequestLayout.unit.spec.js on lines 149..156
    src/applications/vaos/components/layout/CCRequestLayout.unit.spec.js on lines 287..294
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 174..181
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 182..189
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 169..176
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 177..184
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 185..192
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 140..147
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 265..272
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 395..402

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

          expect(
            screen.getByText((content, element) => {
              return (
                element.tagName.toLowerCase() === 'span' &&
                content === 'Reason: Not available'
    src/applications/vaos/components/layout/CCLayout.unit.spec.js on lines 59..66
    src/applications/vaos/components/layout/CCRequestLayout.unit.spec.js on lines 149..156
    src/applications/vaos/components/layout/CCRequestLayout.unit.spec.js on lines 287..294
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 174..181
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 182..189
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 161..168
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 169..176
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 185..192
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 140..147
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 265..272
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 395..402

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

          expect(
            screen.getByText((content, element) => {
              return (
                element.tagName.toLowerCase() === 'span' &&
                content === 'Clinic: Not available'
    src/applications/vaos/components/layout/CCLayout.unit.spec.js on lines 59..66
    src/applications/vaos/components/layout/CCRequestLayout.unit.spec.js on lines 149..156
    src/applications/vaos/components/layout/CCRequestLayout.unit.spec.js on lines 287..294
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 174..181
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 182..189
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 161..168
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 177..184
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 185..192
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 140..147
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 265..272
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 395..402

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

          expect(
            screen.getByText((content, element) => {
              return (
                element.tagName.toLowerCase() === 'span' &&
                content === 'Other details: Not available'
    src/applications/vaos/components/layout/CCLayout.unit.spec.js on lines 59..66
    src/applications/vaos/components/layout/CCRequestLayout.unit.spec.js on lines 149..156
    src/applications/vaos/components/layout/CCRequestLayout.unit.spec.js on lines 287..294
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 174..181
    src/applications/vaos/components/layout/ClaimExamLayout.unit.spec.js on lines 182..189
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 161..168
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 169..176
    src/applications/vaos/components/layout/InPersonLayout.unit.spec.js on lines 177..184
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 140..147
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 265..272
    src/applications/vaos/components/layout/VARequestLayout.unit.spec.js on lines 395..402

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status