department-of-veterans-affairs/vets-website

View on GitHub
src/applications/vaos/components/layouts/CCRequestLayout.unit.spec.js

Summary

Maintainability
D
1 day
Test Coverage

File CCRequestLayout.unit.spec.js has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import { expect } from 'chai';
import {
  createTestStore,
  renderWithStoreAndRouter,
Severity: Minor
Found in src/applications/vaos/components/layouts/CCRequestLayout.unit.spec.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          const appointment = {
            patientComments: 'This is a test:Additional information',
            contact: {
              telecom: [
                {
    src/applications/vaos/components/layouts/CCRequestLayout.unit.spec.js on lines 36..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 131.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          const appointment = {
            patientComments: 'This is a test:Additional information',
            contact: {
              telecom: [
                {
    src/applications/vaos/components/layouts/CCRequestLayout.unit.spec.js on lines 186..218

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 131.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      const initialState = {
        appointments: {
          facilityData: {
            '983': {
              address: {
    src/applications/vaos/components/VideoLink.unit.spec.js on lines 22..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

          expect(
            screen.getByText((content, element) => {
              return (
                element.tagName.toLowerCase() === 'span' &&
                content === 'Email: user@va.gov'
    src/applications/vaos/components/layouts/CCLayout.unit.spec.js on lines 59..66
    src/applications/vaos/components/layouts/CCRequestLayout.unit.spec.js on lines 300..307
    src/applications/vaos/components/layouts/ClaimExamLayout.unit.spec.js on lines 176..183
    src/applications/vaos/components/layouts/ClaimExamLayout.unit.spec.js on lines 184..191
    src/applications/vaos/components/layouts/InPersonLayout.unit.spec.js on lines 163..170
    src/applications/vaos/components/layouts/InPersonLayout.unit.spec.js on lines 171..178
    src/applications/vaos/components/layouts/InPersonLayout.unit.spec.js on lines 179..186
    src/applications/vaos/components/layouts/InPersonLayout.unit.spec.js on lines 187..194
    src/applications/vaos/components/layouts/VARequestLayout.unit.spec.js on lines 147..154
    src/applications/vaos/components/layouts/VARequestLayout.unit.spec.js on lines 285..292
    src/applications/vaos/components/layouts/VARequestLayout.unit.spec.js on lines 415..422

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

          expect(
            screen.getByText((content, element) => {
              return (
                element.tagName.toLowerCase() === 'span' &&
                content === 'Email: user@va.gov'
    src/applications/vaos/components/layouts/CCLayout.unit.spec.js on lines 59..66
    src/applications/vaos/components/layouts/CCRequestLayout.unit.spec.js on lines 149..156
    src/applications/vaos/components/layouts/ClaimExamLayout.unit.spec.js on lines 176..183
    src/applications/vaos/components/layouts/ClaimExamLayout.unit.spec.js on lines 184..191
    src/applications/vaos/components/layouts/InPersonLayout.unit.spec.js on lines 163..170
    src/applications/vaos/components/layouts/InPersonLayout.unit.spec.js on lines 171..178
    src/applications/vaos/components/layouts/InPersonLayout.unit.spec.js on lines 179..186
    src/applications/vaos/components/layouts/InPersonLayout.unit.spec.js on lines 187..194
    src/applications/vaos/components/layouts/VARequestLayout.unit.spec.js on lines 147..154
    src/applications/vaos/components/layouts/VARequestLayout.unit.spec.js on lines 285..292
    src/applications/vaos/components/layouts/VARequestLayout.unit.spec.js on lines 415..422

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status