department-of-veterans-affairs/vets-website

View on GitHub
src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js

Summary

Maintainability
C
1 day
Test Coverage

File index.direct.unit.spec.js has 305 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import moment from 'moment';
import { expect } from 'chai';
import userEvent from '@testing-library/user-event';
import { waitFor, within } from '@testing-library/dom';

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            facilities: {
              '323': [
                {
                  id: '983',
                  name: 'Cheyenne VA Medical Center',
    src/applications/vaos/new-appointment/components/ReviewPage/index.va-request.unit.spec.js on lines 55..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        editLinks.forEach(link => {
          expect(link).to.have.attribute('aria-label');
          uniqueLinks.add(link.getAttribute('aria-label'));
        });
    src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js on lines 161..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        setFetchJSONFailure(
          global.fetch.withArgs(`${environment.API_URL}/vaos/v2/appointments`),
          {
            errors: [{ code: 'VAOS_500' }],
          },
    src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js on lines 169..178
    src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js on lines 203..212
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 247..256
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 286..295
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 325..334

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        setFetchJSONFailure(
          global.fetch.withArgs(`${environment.API_URL}/vaos/v2/appointments`),
          {
            errors: [
              {
    src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js on lines 169..178
    src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js on lines 203..212
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 206..211
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 247..256
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 325..334

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        setFetchJSONFailure(
          global.fetch.withArgs(`${environment.API_URL}/vaos/v2/appointments`),
          {
            errors: [
              {
    src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js on lines 169..178
    src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js on lines 203..212
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 206..211
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 247..256
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 286..295

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        setFetchJSONFailure(
          global.fetch.withArgs(`${environment.API_URL}/vaos/v2/appointments`),
          {
            errors: [
              {
    src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js on lines 169..178
    src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js on lines 203..212
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 206..211
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 286..295
    src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js on lines 325..334

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status