department-of-veterans-affairs/vets-website

View on GitHub
src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js

Summary

Maintainability
F
1 wk
Test Coverage

File ReferralsAndRequests.unit.spec.js has 434 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import userEvent from '@testing-library/user-event';
import moment from 'moment';
import MockDate from 'mockdate';
import { mockFetch } from '@department-of-veterans-affairs/platform-testing/helpers';

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        appointment.attributes = {
          comment: 'A message from the patient',
          contact: {
            telecom: [
              { type: 'phone', value: '2125551212' },
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 41..91
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 132..182
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 265..315
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 262..312

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 266.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        appointment.attributes = {
          comment: 'A message from the patient',
          contact: {
            telecom: [
              { type: 'phone', value: '2125551212' },
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 41..91
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 132..182
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 265..315
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 390..440

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 266.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        appointment.attributes = {
          comment: 'A message from the patient',
          contact: {
            telecom: [
              { type: 'phone', value: '2125551212' },
    src/applications/vaos/appointment-list/components/BackendAppointmentServiceAlert.unit.spec.js on lines 298..348
    src/applications/vaos/appointment-list/components/BackendAppointmentServiceAlert.unit.spec.js on lines 390..440
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 34..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 264.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      it('should display loading if one or more are loading', async () => {
        const initialState = {
          ...initialStateVAOSService,
          referral: {
            referrals: [],
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 67..83
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 101..121
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 122..142
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 143..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      it('should display error message if both calls fail', async () => {
        const initialState = {
          ...initialStateVAOSService,
          referral: {
            referrals: [],
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 84..100
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 101..121
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 122..142
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 143..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      it('should display no referrals message if there are no referrals', async () => {
        const initialState = {
          ...initialStateVAOSService,
          referral: {
            referrals: [],
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 67..83
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 84..100
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 101..121
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 122..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      it('should display referral error message if referrals fail', async () => {
        const initialState = {
          ...initialStateVAOSService,
          referral: {
            referrals: [],
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 67..83
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 84..100
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 122..142
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 143..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      it('should display requests error message if requests fail', async () => {
        const initialState = {
          ...initialStateVAOSService,
          referral: {
            referrals: [],
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 67..83
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 84..100
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 101..121
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 143..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
          start: moment()
            .subtract(120, 'days')
            .format('YYYY-MM-DD'),
          end: moment()
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 229..238

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
          start: moment()
            .subtract(120, 'days')
            .format('YYYY-MM-DD'),
          end: moment()
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 95..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
          start: moment()
            .subtract(120, 'days')
            .format('YYYY-MM-DD'),
          end: moment()
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 93..102
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 157..166
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 185..194
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 318..327
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 315..324

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        mockVAOSAppointmentsFetch({
          start: moment()
            .subtract(120, 'days')
            .format('YYYY-MM-DD'),
          end: moment()
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 93..102
    src/applications/vaos/appointment-list/components/RequestedAppointmentsList.unit.spec.js on lines 157..166
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 185..194
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 318..327
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 443..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const initialState = {
          ...initialStateVAOSService,
          referral: {
            referrals: createReferrals(3, '2024-11-20'),
            referralsFetchStatus: FETCH_STATUS.failed,
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 33..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const initialState = {
          ...initialStateVAOSService,
          referral: {
            referrals: createReferrals(3, '2024-11-20'),
            referralsFetchStatus: FETCH_STATUS.succeeded,
    src/applications/vaos/referral-appointments/ReferralsAndRequests.unit.spec.js on lines 51..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(
          screen.queryByRole('heading', {
            level: 3,
            name: /You don’t have any/,
          }),
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 218..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(
          screen.queryByRole('heading', { level: 2, name: 'Canceled requests' }),
        ).not.to.be.ok;
    src/applications/vaos/appointment-list/components/RequestedAppointmentsListGroup.unit.spec.js on lines 211..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status