Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/platform/forms-system/src/js/definitions/profileAddress.js

Summary

Maintainability
F
3 days
Test Coverage

Function addressUiSchema has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

export default function addressUiSchema(
  path = 'address',
  checkBoxTitle = 'I live on a United States military base outside of the U.S.',
  uiRequiredCallback = () => false,
  newSchemaKeys = {},
Severity: Minor
Found in src/platform/forms-system/src/js/definitions/profileAddress.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File profileAddress.js has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * This uiSchema is modeled after how addresses are handled in the Profile application, and makes the same pattern
 * available for use inside forms generated by the platform's form system.
 */
Severity: Minor
Found in src/platform/forms-system/src/js/definitions/profileAddress.js - About 2 hrs to fix

    Function updateFormDataAddress has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    export const updateFormDataAddress = (
  oldFormData,
  formData,
  path,
  index = null, // this is included in the path, but added as
    Severity: Minor
    Found in src/platform/forms-system/src/js/definitions/profileAddress.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateFormDataAddress has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const updateFormDataAddress = (
  oldFormData,
  formData,
  path,
  index = null, // this is included in the path, but added as
    Severity: Minor
    Found in src/platform/forms-system/src/js/definitions/profileAddress.js - About 1 hr to fix

      Function addressUiSchema has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        path = 'address',
  checkBoxTitle = 'I live on a United States military base outside of the U.S.',
  uiRequiredCallback = () => false,
  newSchemaKeys = {},
  onlyAllowUSAddresses = false,
      Severity: Minor
      Found in src/platform/forms-system/src/js/definitions/profileAddress.js - About 35 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        export const updateFormDataAddress = (
  oldFormData,
  formData,
  path,
  index = null, // this is included in the path, but added as
        Severity: Major
        Found in src/platform/forms-system/src/js/definitions/profileAddress.js and 1 other location - About 2 days to fix
        src/platform/forms-system/src/js/web-component-patterns/addressPattern.jsx on lines 143..190

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 378.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        export const schemaCrossXRef = {
  isMilitary: 'isMilitary',
  'view:militaryBaseDescription': 'view:militaryBaseDescription',
  country: 'country',
  street: 'street',
        Severity: Minor
        Found in src/platform/forms-system/src/js/definitions/profileAddress.js and 1 other location - About 50 mins to fix
        src/platform/forms-system/src/js/web-component-patterns/addressPattern.jsx on lines 65..75

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status