Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/platform/forms/save-in-progress/actions.js

Summary

Maintainability
C
1 day
Test Coverage

File actions.js has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as Sentry from '@sentry/browser';

import recordEvent from '../../monitoring/record-event';
import { logOut } from '../../user/authentication/actions';
import { apiRequest } from '../../utilities/api';
Severity: Minor
Found in src/platform/forms/save-in-progress/actions.js - About 3 hrs to fix

    Function fetchInProgressForm has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function fetchInProgressForm(
  formId,
  migrations,
  prefill = false,
  prefillTransformer = null,
    Severity: Major
    Found in src/platform/forms/save-in-progress/actions.js - About 3 hrs to fix

      Function saveForm has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function saveForm(saveType, formId, formData, version, returnUrl, submission) {
  const savedAt = Date.now();

  return (dispatch, getState) => {
    const { trackingPrefix } = getState().form;
      Severity: Minor
      Found in src/platform/forms/save-in-progress/actions.js - About 1 hr to fix

        Function saveForm has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function saveForm(saveType, formId, formData, version, returnUrl, submission) {
        Severity: Minor
        Found in src/platform/forms/save-in-progress/actions.js - About 45 mins to fix

          Function setSaveFormStatus has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            saveType,
  status,
  lastSavedDate = null,
  expirationDate = null,
  inProgressFormId = null,
          Severity: Minor
          Found in src/platform/forms/save-in-progress/actions.js - About 35 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            export const LOAD_STATUSES = Object.freeze({
  notAttempted: 'not-attempted',
  pending: 'pending',
  noAuth: 'no-auth',
  failure: 'failure',
            Severity: Major
            Found in src/platform/forms/save-in-progress/actions.js and 3 other locations - About 1 hr to fix
            src/applications/letters/utils/constants.js on lines 26..35
            src/applications/simple-forms/21-4138/config/constants.js on lines 107..119
            src/applications/disability-benefits/all-claims/constants.js on lines 395..405

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            export const SAVE_STATUSES = Object.freeze({
  notAttempted: 'not-attempted',
  pending: 'pending',
  noAuth: 'no-auth',
  failure: 'failure',
            Severity: Major
            Found in src/platform/forms/save-in-progress/actions.js and 2 other locations - About 40 mins to fix
            src/applications/accredited-representative-portal/accreditation/21a/constants/options.js on lines 14..21
            src/applications/simple-forms/21-4138/config/constants.js on lines 49..56

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status