Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/platform/pdf/templates/blue_button_report.js

Summary

Maintainability
F
4 days
Test Coverage

File blue_button_report.js has 420 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Blue Button PDF template.
 *
 * NB: The order in which items are added to the document is important,
 * and thus PDFKit requires performing operations synchronously.
Severity: Minor
Found in src/platform/pdf/templates/blue_button_report.js - About 6 hrs to fix

    Function generate has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    const generate = async data => {
  validate(data);
  const tocPageData = {};
  const doc = createAccessibleDoc(data, config);
    Severity: Minor
    Found in src/platform/pdf/templates/blue_button_report.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generate has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const generate = async data => {
  validate(data);
  const tocPageData = {};
  const doc = createAccessibleDoc(data, config);
    Severity: Minor
    Found in src/platform/pdf/templates/blue_button_report.js - About 1 hr to fix

      Function generateResultsContent has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const generateResultsContent = async (doc, parent, data) => {
  const results = doc.struct('Sect', {
    title: 'Results',
  });
  parent.add(results);
      Severity: Minor
      Found in src/platform/pdf/templates/blue_button_report.js - About 1 hr to fix

        Function generateTitleSection has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const generateTitleSection = (doc, parent, data) => {
  const titleSection = doc.struct('Sect', {
    title: 'Introduction',
  });
  parent.add(titleSection);
        Severity: Minor
        Found in src/platform/pdf/templates/blue_button_report.js - About 1 hr to fix

          Function generateInfoSection has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const generateInfoSection = (doc, parent) => {
  const infoSection = doc.struct('Sect', {
    title: 'Information',
  });
  infoSection.add(
          Severity: Minor
          Found in src/platform/pdf/templates/blue_button_report.js - About 1 hr to fix

            Function generateResultItemContent has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            const generateResultItemContent = async (
  item,
  doc,
  results,
  hasHorizontalRule,
            Severity: Minor
            Found in src/platform/pdf/templates/blue_button_report.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function generateHelpSection has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const generateHelpSection = (doc, parent) => {
  const infoSection = doc.struct('Sect', {
    title: 'Information',
  });
  infoSection.add(
            Severity: Minor
            Found in src/platform/pdf/templates/blue_button_report.js - About 1 hr to fix

              Function generateTocItem has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const generateTocItem = (doc, parent, data, pageData) => {
  const leftMargin = 100;
  const pages =
    pageData.startPage === pageData.endPage
      ? `page ${pageData.startPage}`
              Severity: Minor
              Found in src/platform/pdf/templates/blue_button_report.js - About 1 hr to fix

                Function generateResultsContent has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                export const generateResultsContent = async (doc, parent, data) => {
  const results = doc.struct('Sect', {
    title: 'Results',
  });
  parent.add(results);
                Severity: Minor
                Found in src/platform/pdf/templates/blue_button_report.js - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                const generateDetailsContent = async (doc, parent, data) => {
  const details = doc.struct('Sect', {
    title: 'Details',
  });
  parent.add(details);
                Severity: Major
                Found in src/platform/pdf/templates/blue_button_report.js and 1 other location - About 1 day to fix
                src/platform/pdf/templates/medical_records.js on lines 74..94

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 199.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  if (data.results.items.length === 1) {
    await generateResultItemContent(
      data.results.items[0],
      doc,
      results,
                Severity: Major
                Found in src/platform/pdf/templates/blue_button_report.js and 1 other location - About 4 hrs to fix
                src/platform/pdf/templates/medical_records.js on lines 142..169

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 130.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  if (data.results.preface) {
    const prefaceOptions = {
      paragraphGap: 12,
      x: 30,
    };
                Severity: Major
                Found in src/platform/pdf/templates/blue_button_report.js and 1 other location - About 1 hr to fix
                src/platform/pdf/templates/medical_records.js on lines 134..139

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status