Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/platform/pdf/templates/veteran_status_new.js

Summary

Maintainability
D
2 days
Test Coverage

Function generate has 203 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const generate = async data => {
  validate(data.details);

  const doc = createAccessibleDoc(data, config);
Severity: Major
Found in src/platform/pdf/templates/veteran_status_new.js - About 1 day to fix

    File veteran_status_new.js has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Proof of Veteran Status PDF template.
 *
 * NB: The order in which items are added to the document is important,
 * and thus PDFKit requires performing operations synchronously.
    Severity: Minor
    Found in src/platform/pdf/templates/veteran_status_new.js - About 2 hrs to fix

      Function generate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      const generate = async data => {
  validate(data.details);

  const doc = createAccessibleDoc(data, config);
      Severity: Minor
      Found in src/platform/pdf/templates/veteran_status_new.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            const content = doc.struct('P', () => {
        doc
          .font(config.text.font)
          .fontSize(config.text.size)
          .text(item.content)
      Severity: Major
      Found in src/platform/pdf/templates/veteran_status_new.js and 2 other locations - About 2 hrs to fix
      src/platform/pdf/templates/veteran_status.js on lines 128..134
      src/platform/pdf/templates/veteran_status_new.js on lines 228..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          const content = doc.struct('P', () => {
      doc
        .font(config.text.font)
        .fontSize(config.text.size)
        .text(item.content)
      Severity: Major
      Found in src/platform/pdf/templates/veteran_status_new.js and 2 other locations - About 2 hrs to fix
      src/platform/pdf/templates/veteran_status.js on lines 128..134
      src/platform/pdf/templates/veteran_status_new.js on lines 255..261

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          {
      heading: 'VA disability rating',
      content: `${data.details.totalDisabilityRating?.toString()}%`,
      condition: data.details.totalDisabilityRating,
    },
      Severity: Minor
      Found in src/platform/pdf/templates/veteran_status_new.js and 1 other location - About 40 mins to fix
      src/platform/pdf/templates/veteran_status.js on lines 113..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          doc
      .font(config.headings.H2.font)
      .fontSize(config.headings.H2.size)
      .text(
        'Proof of Veteran Status',
      Severity: Major
      Found in src/platform/pdf/templates/veteran_status_new.js and 3 other locations - About 35 mins to fix
      src/platform/pdf/templates/veteran_status.js on lines 97..100
      src/platform/pdf/templates/veteran_status.js on lines 123..126
      src/platform/pdf/templates/veteran_status.js on lines 142..145

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status