Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/platform/site-wide/legacy-component-js/accordion.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function addAccordionClickHandler has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const addAccordionClickHandler = () => {
  Array.from(
    document.querySelectorAll('.usa-accordion, .usa-accordion-bordered'),
  ).forEach(element => {
    const parents = getAccordionParents(element);
Severity: Major
Found in src/platform/site-wide/legacy-component-js/accordion.js - About 2 hrs to fix

    Function autoExpandAccordionPanelByUrlHash has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function autoExpandAccordionPanelByUrlHash() {
  const { hash } = document.location;

  if (!hash) {
    return;
    Severity: Minor
    Found in src/platform/site-wide/legacy-component-js/accordion.js - About 1 hr to fix

      Function getAccordionParents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      const getAccordionParents = elem => {
  // Setup parents array
  const parents = [];

  // Get matching parent elements
      Severity: Minor
      Found in src/platform/site-wide/legacy-component-js/accordion.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status