Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/platform/user/authentication/utilities.js

Summary

Maintainability
C
1 day
Test Coverage

File utilities.js has 350 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import appendQuery from 'append-query';
import * as Sentry from '@sentry/browser';
import 'url-search-params-polyfill';
import environment from 'platform/utilities/environment';
import { createOAuthRequest } from 'platform/utilities/oauth/utilities';
Severity: Minor
Found in src/platform/user/authentication/utilities.js - About 4 hrs to fix

    Function sessionTypeUrl has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    export function sessionTypeUrl({
  type = '',
  queryParams = {},
  version = API_VERSION,
  allowVerification = false,
    Severity: Minor
    Found in src/platform/user/authentication/utilities.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createExternalApplicationUrl has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const createExternalApplicationUrl = () => {
  const { application, to } = getQueryParams();
  if (!application) {
    return null;
  }
    Severity: Minor
    Found in src/platform/user/authentication/utilities.js - About 1 hr to fix

      Function createAndStoreReturnUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const createAndStoreReturnUrl = () => {
  let returnUrl;
  if (loginAppUrlRE.test(window.location.pathname)) {
    if (isExternalRedirect()) {
      returnUrl = createExternalApplicationUrl();
      Severity: Minor
      Found in src/platform/user/authentication/utilities.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createExternalApplicationUrl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export const createExternalApplicationUrl = () => {
  const { application, to } = getQueryParams();
  if (!application) {
    return null;
  }
      Severity: Minor
      Found in src/platform/user/authentication/utilities.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status