Sign upLogin

descholar-ceo/AnnounceIT

View on GitHub
Star
server/v2/models/user.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function passwordReset has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async passwordReset(dataFromTheUser) {
        const { email, oldpassword, newpassword } = dataFromTheUser;
        const isEmailExist = await this.checkIfEmailExistsFromDb(dataFromTheUser);
        if (isEmailExist) {
Severity: Major
Found in server/v2/models/user.js - About 2 hrs to fix

    Function passwordReset has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        async passwordReset(dataFromTheUser) {
        const { email, oldpassword, newpassword } = dataFromTheUser;
        const isEmailExist = await this.checkIfEmailExistsFromDb(dataFromTheUser);
        if (isEmailExist) {
    Severity: Minor
    Found in server/v2/models/user.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return {
                status: 1,
                error:'unknown credentials'
            }
    Severity: Major
    Found in server/v2/models/user.js - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status