Sign upLogin

dhis2/d2-ui

View on GitHub
Star
packages/interpretations/src/authorization/auth.js

Summary

Maintainability
D
2 days
Test Coverage

Function haveReadAccess has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export const haveReadAccess = (d2, userGroups, object) => {
    const { currentUser } = d2 || {};

    if (!object || !currentUser) {
        return false;
Severity: Minor
Found in packages/interpretations/src/authorization/auth.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function haveWriteAccess has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export const haveWriteAccess = (d2, userGroups, object) => {
    const { currentUser } = d2 || {};

    if (!object || !currentUser) {
        return false;
Severity: Minor
Found in packages/interpretations/src/authorization/auth.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return true;
Severity: Major
Found in packages/interpretations/src/authorization/auth.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return false;
    Severity: Major
    Found in packages/interpretations/src/authorization/auth.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return true;
      Severity: Major
      Found in packages/interpretations/src/authorization/auth.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return true;
        Severity: Major
        Found in packages/interpretations/src/authorization/auth.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return true;
          Severity: Major
          Found in packages/interpretations/src/authorization/auth.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return false;
            Severity: Major
            Found in packages/interpretations/src/authorization/auth.js - About 30 mins to fix

              Function userCanManage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              export const userCanManage = (d2, object) => {
    const { currentUser } = d2 || {};

    if (!object || !object.user || !currentUser) {
        return false;
              Severity: Minor
              Found in packages/interpretations/src/authorization/auth.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              export const haveReadAccess = (d2, userGroups, object) => {
    const { currentUser } = d2 || {};

    if (!object || !currentUser) {
        return false;
              Severity: Major
              Found in packages/interpretations/src/authorization/auth.js and 1 other location - About 1 day to fix
              packages/interpretations/src/authorization/auth.js on lines 37..55

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 196.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              export const haveWriteAccess = (d2, userGroups, object) => {
    const { currentUser } = d2 || {};

    if (!object || !currentUser) {
        return false;
              Severity: Major
              Found in packages/interpretations/src/authorization/auth.js and 1 other location - About 1 day to fix
              packages/interpretations/src/authorization/auth.js on lines 17..35

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 196.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status