Sign upLogin

dhis2/d2-ui

View on GitHub
Star
packages/interpretations/src/components/DetailsPanel/Details.js

Summary

Maintainability
C
1 day
Test Coverage

Function renderSubscriptionButton has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    renderSubscriptionButton() {
        const tOpts = { object: translateModelName(this.props.model.modelName) };
        const [SubscriberIcon, subscriptionTooltip] = this.props.model.subscribed
            ? [
                  SubscriberIconEnabled,
Severity: Minor
Found in packages/interpretations/src/components/DetailsPanel/Details.js - About 1 hr to fix

    Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        const { model, classes } = this.props;
        const owner = model.user ? model.user.displayName : '-';
        const SubscriptionButton = this.renderSubscriptionButton();
    Severity: Minor
    Found in packages/interpretations/src/components/DetailsPanel/Details.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          getCardTitle = (type) => {
        const typeTitleMap = {
            REPORT_TABLE: i18n.t('Table details'),
            CHART: i18n.t('Chart details'),
            MAP: i18n.t('Map details'),
      Severity: Major
      Found in packages/interpretations/src/components/DetailsPanel/Details.js and 1 other location - About 3 hrs to fix
      packages/interpretations/src/components/Buttons/RedirectButton.js on lines 9..21

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      Details.contextTypes = {
    d2: PropTypes.object.isRequired,
    locale: PropTypes.string.isRequired,
    appName: PropTypes.string.isRequired,
};
      Severity: Major
      Found in packages/interpretations/src/components/DetailsPanel/Details.js and 3 other locations - About 50 mins to fix
      packages/interpretations/src/components/Buttons/ActionButton.js on lines 77..81
      packages/interpretations/src/components/Cards/CardText.js on lines 23..27
      packages/interpretations/src/components/Cards/CollapsibleCard.js on lines 51..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      Details.propTypes = {
    isOffline: PropTypes.bool,
    model: PropTypes.object.isRequired,
    onChange: PropTypes.func.isRequired,
};
      Severity: Minor
      Found in packages/interpretations/src/components/DetailsPanel/Details.js and 1 other location - About 35 mins to fix
      packages/interpretations/src/components/DetailsPanel/Description.js on lines 45..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          <Item
                        label={i18n.t('Last updated')}
                        text={formatDate(model.lastUpdated, this.context.locale)}
                    />
      Severity: Minor
      Found in packages/interpretations/src/components/DetailsPanel/Details.js and 1 other location - About 35 mins to fix
      packages/interpretations/src/components/DetailsPanel/Details.js on lines 106..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          <Item
                        label={i18n.t('Created')}
                        text={formatDate(model.created, this.context.locale)}
                    />
      Severity: Minor
      Found in packages/interpretations/src/components/DetailsPanel/Details.js and 1 other location - About 35 mins to fix
      packages/interpretations/src/components/DetailsPanel/Details.js on lines 110..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status