Sign upLogin

dhis2/d2

View on GitHub
Star
src/analytics/__tests__/AnalyticsAggregate.spec.js

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Confirmed

    it('should use the api object when it is passed', () => {
        const apiMockObject = {}

        aggregate = new AnalyticsAggregate(apiMockObject)
Severity: Major
Found in src/analytics/__tests__/AnalyticsAggregate.spec.js and 3 other locations - About 50 mins to fix
src/analytics/__tests__/AnalyticsBase.spec.js on lines 24..30
src/analytics/__tests__/AnalyticsEvents.spec.js on lines 28..34
src/system/__tests__/SystemConfiguration.spec.js on lines 105..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

        it('should resolve a promise with data', () =>
            aggregate.getDebugSql(request).then((data) => {
                expect(data).toEqual(debugSqlFixture)
            }))
Severity: Minor
Found in src/analytics/__tests__/AnalyticsAggregate.spec.js and 1 other location - About 40 mins to fix
src/analytics/__tests__/AnalyticsEvents.spec.js on lines 51..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Confirmed

    beforeEach(() => {
        mockApi = MockApi.getApi()
        MockApi.mockClear()
        aggregate = new AnalyticsAggregate()
    })
Severity: Minor
Found in src/analytics/__tests__/AnalyticsAggregate.spec.js and 2 other locations - About 35 mins to fix
src/analytics/__tests__/AnalyticsEvents.spec.js on lines 14..18
src/system/__tests__/SystemConfiguration.spec.js on lines 83..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status