Sign upLogin

dhis2/d2

View on GitHub
Star
src/model/__tests__/ModelCollectionProperty.spec.js

Summary

Maintainability
D
2 days
Test Coverage

File ModelCollectionProperty.spec.js has 389 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import fixtures from '../../__fixtures__/fixtures'
import Api from '../../api/Api'
import Model from '../Model'
import ModelDefinition from '../ModelDefinition'
import ModelCollectionProperty from '../ModelCollectionProperty'
Severity: Minor
Found in src/model/__tests__/ModelCollectionProperty.spec.js - About 5 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('Sets the dirty flag to false when an element is added and then removed', () => {
            expect(mcp.dirty).toBe(false)
            mcp.add(testModels[0])
            expect(mcp.dirty).toBe(true)
            mcp.remove(testModels[0])
    Severity: Major
    Found in src/model/__tests__/ModelCollectionProperty.spec.js and 1 other location - About 3 hrs to fix
    src/model/__tests__/ModelCollectionProperty.spec.js on lines 136..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('Sets the dirty flag to false when an element is removed and re-added', () => {
            expect(mcp.dirty).toBe(false)
            mcp.remove(testModels[0])
            expect(mcp.dirty).toBe(true)
            mcp.add(testModels[0])
    Severity: Major
    Found in src/model/__tests__/ModelCollectionProperty.spec.js and 1 other location - About 3 hrs to fix
    src/model/__tests__/ModelCollectionProperty.spec.js on lines 92..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('Updates the dirty flag', () => {
            expect(mcp.dirty).toBe(false)
            mcp.add(testModels[0])
            expect(mcp.dirty).toBe(true)
        })
    Severity: Major
    Found in src/model/__tests__/ModelCollectionProperty.spec.js and 1 other location - About 1 hr to fix
    src/model/__tests__/ModelCollectionProperty.spec.js on lines 130..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('Updates the dirty flag', () => {
            expect(mcp.dirty).toBe(false)
            mcp.remove(testModels[0])
            expect(mcp.dirty).toBe(true)
        })
    Severity: Major
    Found in src/model/__tests__/ModelCollectionProperty.spec.js and 1 other location - About 1 hr to fix
    src/model/__tests__/ModelCollectionProperty.spec.js on lines 86..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                return unloadedWithValues
                .load({ paging: false, fields: 'id,displayName' })
                .then(() => {
                    expect(api.get).toHaveBeenCalledWith(
                        [
    Severity: Major
    Found in src/model/__tests__/ModelCollectionProperty.spec.js and 1 other location - About 1 hr to fix
    src/model/__tests__/ModelCollectionProperty.spec.js on lines 404..415

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                return unloadedWithValues.load().then(() => {
                expect(api.get).toHaveBeenCalledWith(
                    [
                        mockParentModel.modelDefinition.apiEndpoint,
                        mockParentModel.id,
    Severity: Major
    Found in src/model/__tests__/ModelCollectionProperty.spec.js and 1 other location - About 1 hr to fix
    src/model/__tests__/ModelCollectionProperty.spec.js on lines 421..434

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status