Sign upLogin

dianhua1560/bhgh

View on GitHub
Star

Showing 2 of 208 total issues

File boardCtrl.js has 328 lines of code (exceeds 250 allowed). Consider refactoring.
Open

myApp.controller("BoardCtrl", function ($scope) {
    $scope.events = events;
    $scope.brags = brags;
    $scope.posts = posts;
    $scope.newEvent = {};
Severity: Minor
Found in public/controllers/boardCtrl.js - About 3 hrs to fix

    Method delete_post has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def delete_post
        post = Post.find(params[:id])
        if post.author == myEmail or Member.is_admin_email(myEmail)
            post.destroy
            if request.get?
    Severity: Minor
    Found in app/controllers/forum_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language