Sign upLogin

dice-cyfronet/plgapp

View on GitHub
Star
public/plgapp/datanet.js

Summary

Maintainability
F
5 days
Test Coverage

Function DataNetChainFactory has a Cognitive Complexity of 76 (exceeds 5 allowed). Consider refactoring.
Open

var DataNetChainFactory = function(repositoryName, controller) {
    this.repositoryName = repositoryName;
    this.controller = controller;
    this.urlBase = '/datanet/{repoName}/';
    this.fieldValues = {};
Severity: Minor
Found in public/plgapp/datanet.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function DataNetChainFactory has 152 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var DataNetChainFactory = function(repositoryName, controller) {
    this.repositoryName = repositoryName;
    this.controller = controller;
    this.urlBase = '/datanet/{repoName}/';
    this.fieldValues = {};
Severity: Major
Found in public/plgapp/datanet.js - About 6 hrs to fix

    Function DataNet has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    var DataNet = function() {
    var factory = null;
    
    this.repository = function(name) {
        factory = new DataNetChainFactory(name, this);
    Severity: Minor
    Found in public/plgapp/datanet.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function DataNet has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var DataNet = function() {
    var factory = null;
    
    this.repository = function(name) {
        factory = new DataNetChainFactory(name, this);
    Severity: Major
    Found in public/plgapp/datanet.js - About 3 hrs to fix

      Function then has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          this.then = function(successCallback, errorCallback) {
        switch(this.action) {
            case undefined:
            case null:
                errorCallback('None of the action methods were called (action methods: create(), get(), delete(), update(), search())');
      Severity: Major
      Found in public/plgapp/datanet.js - About 2 hrs to fix

        Function processFetchResult has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            this.processFetchResult = function(data, successCallback) {
        if(this.fieldNames.length > 0) {
            if(Array.isArray(data)) {
                var result = [];
                var object = {};
        Severity: Minor
        Found in public/plgapp/datanet.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.update = function(updateUrl, values, successCallback, errorCallback) {
        plgapp.getInfo(function(error, userLogin, csrfToken) {
            if(error) {
                errorCallback(error.message);
            } else {
          Severity: Major
          Found in public/plgapp/datanet.js and 1 other location - About 6 hrs to fix
          public/plgapp/datanet.js on lines 208..228

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 156.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.addEntityEntry = function(entityUrl, values, successCallback, errorCallback) {
        plgapp.getInfo(function(error, userLogin, csrfToken) {
            if(error) {
                errorCallback(error.message);
            } else {
          Severity: Major
          Found in public/plgapp/datanet.js and 1 other location - About 6 hrs to fix
          public/plgapp/datanet.js on lines 243..263

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 156.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status