Sign upLogin

digitalheir/bibliography-js

View on GitHub
Star

Showing 52 of 101 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    {"name": "braced_string$ebnf$1", "symbols": ["braced_string$ebnf$1$subexpression$1", "braced_string$ebnf$1"], "postprocess": function arrconcat(d) {return [d[0]].concat(d[1]);}},
Severity: Major
Found in depr/bibtex/parser/parser.js and 8 other locations - About 40 mins to fix
depr/bibtex/parser/parser.js on lines 54..54
depr/bibtex/parser/parser.js on lines 84..84
depr/bibtex/parser/parser.js on lines 117..117
depr/bibtex/parser/parser.js on lines 165..165
depr/bibtex/parser/parser.js on lines 188..188
depr/bibtex/parser/parser.js on lines 192..192
depr/bibtex/parser/parser.js on lines 220..220
depr/bibtex/parser/parser.js on lines 285..285

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    {"name": "comment$ebnf$1", "symbols": ["comment$ebnf$1$subexpression$1", "comment$ebnf$1"], "postprocess": function arrconcat(d) {return [d[0]].concat(d[1]);}},
Severity: Major
Found in depr/bibtex/parser/parser.js and 8 other locations - About 40 mins to fix
depr/bibtex/parser/parser.js on lines 54..54
depr/bibtex/parser/parser.js on lines 117..117
depr/bibtex/parser/parser.js on lines 153..153
depr/bibtex/parser/parser.js on lines 165..165
depr/bibtex/parser/parser.js on lines 188..188
depr/bibtex/parser/parser.js on lines 192..192
depr/bibtex/parser/parser.js on lines 220..220
depr/bibtex/parser/parser.js on lines 285..285

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    {"name": "key_string$ebnf$1", "symbols": ["stringreftoken", "key_string$ebnf$1"], "postprocess": function arrconcat(d) {return [d[0]].concat(d[1]);}},
Severity: Major
Found in depr/bibtex/parser/parser.js and 8 other locations - About 40 mins to fix
depr/bibtex/parser/parser.js on lines 54..54
depr/bibtex/parser/parser.js on lines 84..84
depr/bibtex/parser/parser.js on lines 117..117
depr/bibtex/parser/parser.js on lines 153..153
depr/bibtex/parser/parser.js on lines 165..165
depr/bibtex/parser/parser.js on lines 192..192
depr/bibtex/parser/parser.js on lines 220..220
depr/bibtex/parser/parser.js on lines 285..285

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    {"name": "quoted_string$ebnf$1", "symbols": ["quoted_string$ebnf$1$subexpression$1", "quoted_string$ebnf$1"], "postprocess": function arrconcat(d) {return [d[0]].concat(d[1]);}},
Severity: Major
Found in depr/bibtex/parser/parser.js and 8 other locations - About 40 mins to fix
depr/bibtex/parser/parser.js on lines 54..54
depr/bibtex/parser/parser.js on lines 84..84
depr/bibtex/parser/parser.js on lines 117..117
depr/bibtex/parser/parser.js on lines 153..153
depr/bibtex/parser/parser.js on lines 188..188
depr/bibtex/parser/parser.js on lines 192..192
depr/bibtex/parser/parser.js on lines 220..220
depr/bibtex/parser/parser.js on lines 285..285

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    {"name": "bib_content$ebnf$1", "symbols": ["bib_content$ebnf$1$subexpression$1", "bib_content$ebnf$1"], "postprocess": function arrconcat(d) {return [d[0]].concat(d[1]);}},
Severity: Major
Found in depr/bibtex/parser/parser.js and 8 other locations - About 40 mins to fix
depr/bibtex/parser/parser.js on lines 54..54
depr/bibtex/parser/parser.js on lines 84..84
depr/bibtex/parser/parser.js on lines 153..153
depr/bibtex/parser/parser.js on lines 165..165
depr/bibtex/parser/parser.js on lines 188..188
depr/bibtex/parser/parser.js on lines 192..192
depr/bibtex/parser/parser.js on lines 220..220
depr/bibtex/parser/parser.js on lines 285..285

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    {"name": "value_string$subexpression$1$ebnf$1", "symbols": ["value_string$subexpression$1$ebnf$1$subexpression$1", "value_string$subexpression$1$ebnf$1"], "postprocess": function arrconcat(d) {return [d[0]].concat(d[1]);}},
Severity: Major
Found in depr/bibtex/parser/parser.js and 8 other locations - About 40 mins to fix
depr/bibtex/parser/parser.js on lines 54..54
depr/bibtex/parser/parser.js on lines 84..84
depr/bibtex/parser/parser.js on lines 117..117
depr/bibtex/parser/parser.js on lines 153..153
depr/bibtex/parser/parser.js on lines 165..165
depr/bibtex/parser/parser.js on lines 188..188
depr/bibtex/parser/parser.js on lines 220..220
depr/bibtex/parser/parser.js on lines 285..285

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    {"name": "string_ref$subexpression$1$ebnf$1", "symbols": ["stringreftoken", "string_ref$subexpression$1$ebnf$1"], "postprocess": function arrconcat(d) {return [d[0]].concat(d[1]);}},
Severity: Major
Found in depr/bibtex/parser/parser.js and 8 other locations - About 40 mins to fix
depr/bibtex/parser/parser.js on lines 54..54
depr/bibtex/parser/parser.js on lines 84..84
depr/bibtex/parser/parser.js on lines 117..117
depr/bibtex/parser/parser.js on lines 153..153
depr/bibtex/parser/parser.js on lines 165..165
depr/bibtex/parser/parser.js on lines 188..188
depr/bibtex/parser/parser.js on lines 192..192
depr/bibtex/parser/parser.js on lines 285..285

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    {"name": "preamble_entry", "symbols": [entry_type_preamble, "_", "entry_body_comment"], "postprocess": function (data, location, reject) { return {type: 'preamble', data: data[2]}; }},
Severity: Minor
Found in depr/bibtex/parser/parser.js and 2 other locations - About 35 mins to fix
depr/bibtex/parser/parser.js on lines 146..146
depr/bibtex/parser/parser.js on lines 148..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    {"name": "comment_entry", "symbols": [entry_type_comment, "_", "entry_body_comment"], "postprocess": function (data, location, reject) { return {type: 'comment', data: data[2]}; }},
Severity: Minor
Found in depr/bibtex/parser/parser.js and 2 other locations - About 35 mins to fix
depr/bibtex/parser/parser.js on lines 146..146
depr/bibtex/parser/parser.js on lines 147..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    {"name": "string_entry", "symbols": [entry_type_string, "_", "entry_body_string"], "postprocess": function (data, location, reject) { return {type: 'string', data: data[2]}; }},
Severity: Minor
Found in depr/bibtex/parser/parser.js and 2 other locations - About 35 mins to fix
depr/bibtex/parser/parser.js on lines 147..147
depr/bibtex/parser/parser.js on lines 148..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function renderVolume(vol, partOfId?: string) {
  return span("_bib_volume", {
      prop: "isPartOf",//    itemType="https://schema.org/PublicationVolume"
    },
    span("_bib_volume_number", {prop: "isPartOf"}, vol)
Severity: Minor
Found in src/reference/MLA/html/journal.ts and 1 other location - About 30 mins to fix
src/reference/AMA/html/journal.ts on lines 16..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function renderVolume(vol, partOfId?: string) {
  return span("_bib_volume", {
      prop: "isPartOf",//    itemType="https://schema.org/PublicationVolume"
    },
    span("_bib_volume_number", {prop: "isPartOf"}, vol)
Severity: Minor
Found in src/reference/AMA/html/journal.ts and 1 other location - About 30 mins to fix
src/reference/MLA/html/journal.ts on lines 17..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language