Sign upLogin

dimelo/dimelo_ccp_api

View on GitHub
Star

Showing 3 of 6 total issues

Class Model has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Model
      extend ActiveModel::Translation
      extend ActiveModel::Naming
      include ActiveModel::Validations
Severity: Minor
Found in lib/dimelo/ccp/api/model.rb - About 3 hrs to fix

    Method new has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def new(params, &block)
          if (params.has_key?(:offset) || params.has_key?('offset'))
            yield params
          else
            instance = super(params, &block)
    Severity: Minor
    Found in lib/dimelo/ccp/api/lazzy_collection.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method each has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def each(&block)
        index = 0
        while true
          item = paginator.get_item_at(index)
          break if item.nil?
    Severity: Minor
    Found in lib/dimelo/ccp/api/lazzy_collection.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language