Sign upLogin

dinks/bucket_maker

View on GitHub
Star

Showing 3 of 3 total issues

Method in_bucket? has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def in_bucket?(series_name, bucket_name, group_name, force=false)
        # Get the singleton Series Maker
        series_maker = BucketMaker::SeriesMaker.instance

        # Check if the parameters are valid
Severity: Minor
Found in lib/bucket_maker/models/bucketable.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_model has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def generate_model
        invoke "active_record:model", [name], :migration => false unless model_exists? && behavior == :invoke
        if store_in == 'active_record'
          invoke "active_record:model", [ACTIVE_RECORDABLE], :migration => false unless active_recordable_exists? && behavior == :invoke
        end
Severity: Minor
Found in lib/generators/active_record/bucket_maker_generator.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bucketable? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def bucketable?(bucketable, series_name, bucket_name, group_name)
      if  bucketable.has_attribute?(:created_at) &&
          has_group_in_bucket_in_series?(series_name, bucket_name, group_name)

        series_with_name(series_name).bucket_with_name(bucket_name).is_bucketable?(bucketable) ||
Severity: Minor
Found in lib/bucket_maker/series_maker.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language