Sign upLogin

divyanshyadav/data-structures-again

View on GitHub
Star
src/tree/2d-tree/index.js

Summary

Maintainability
D
1 day
Test Coverage

Function getNearestPoint has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    getNearestPoint(x, y) {
        let nearestPoint = null
        let minDistance = Infinity

        function nearestPointHelper(root, x, y, level) {
Severity: Minor
Found in src/tree/2d-tree/index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getNearestPoint has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getNearestPoint(x, y) {
        let nearestPoint = null
        let minDistance = Infinity

        function nearestPointHelper(root, x, y, level) {
Severity: Minor
Found in src/tree/2d-tree/index.js - About 1 hr to fix

    Function insert has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        insert(x, y) {
        function insertHelper(root, x, y, level) {
            if (!root) {
                if (level % 2 === 0) {
                    return new Node(x, { x, y })
    Severity: Minor
    Found in src/tree/2d-tree/index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function rectInLeft has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function rectInLeft(root, x1, x2, y1, y2, level) {
    Severity: Minor
    Found in src/tree/2d-tree/index.js - About 45 mins to fix

      Function rangeSearchHelper has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              function rangeSearchHelper(root, x1, x2, y1, y2, level) {
      Severity: Minor
      Found in src/tree/2d-tree/index.js - About 45 mins to fix

        Function inRect has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function inRect(x, y, x1, x2, y1, y2) {
        Severity: Minor
        Found in src/tree/2d-tree/index.js - About 45 mins to fix

          Function rectInRight has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function rectInRight(root, x1, x2, y1, y2, level) {
          Severity: Minor
          Found in src/tree/2d-tree/index.js - About 45 mins to fix

            Function rangeSearch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                rangeSearch(x1, x2, y1, y2) {
        const result = []
        function rangeSearchHelper(root, x1, x2, y1, y2, level) {
            if (!root) return
            Severity: Minor
            Found in src/tree/2d-tree/index.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function rectInLeft has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function rectInLeft(root, x1, x2, y1, y2, level) {
    const { x, y } = root.value
    if (level % 2 === 0) {
        if (x1 <= x) return true
    } else {
            Severity: Minor
            Found in src/tree/2d-tree/index.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function rectInRight has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function rectInRight(root, x1, x2, y1, y2, level) {
    const { x, y } = root.value
    if (level % 2 === 0) {
        if (x2 > x) return true
    } else {
            Severity: Minor
            Found in src/tree/2d-tree/index.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function rectInLeft(root, x1, x2, y1, y2, level) {
    const { x, y } = root.value
    if (level % 2 === 0) {
        if (x1 <= x) return true
    } else {
            Severity: Major
            Found in src/tree/2d-tree/index.js and 1 other location - About 2 hrs to fix
            src/tree/2d-tree/index.js on lines 139..148

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 80.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function rectInRight(root, x1, x2, y1, y2, level) {
    const { x, y } = root.value
    if (level % 2 === 0) {
        if (x2 > x) return true
    } else {
            Severity: Major
            Found in src/tree/2d-tree/index.js and 1 other location - About 2 hrs to fix
            src/tree/2d-tree/index.js on lines 128..137

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 80.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        } else {
                nearestPointHelper(root.right, x, y, level + 1)
                if (minDistanceFromPlane < minDistance) {
                    nearestPointHelper(root.left, x, y, level + 1)
                }
            Severity: Minor
            Found in src/tree/2d-tree/index.js and 1 other location - About 45 mins to fix
            src/tree/2d-tree/index.js on lines 83..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (isPointLieInLeftOrBottomPlane(root, level, x, y)) {
                nearestPointHelper(root.left, x, y, level + 1)
                if (minDistanceFromPlane < minDistance) {
                    nearestPointHelper(root.right, x, y, level + 1)
                }
            Severity: Minor
            Found in src/tree/2d-tree/index.js and 1 other location - About 45 mins to fix
            src/tree/2d-tree/index.js on lines 88..93

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status