Sign upLogin

dmitry-kulikov/yii2-braintree

View on GitHub
Star

Showing 8 of 271 total issues

File BraintreeForm.php has 397 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * @author Anton Tuyakhov <atuyakhov@gmail.com>
 */
Severity: Minor
Found in src/BraintreeForm.php - About 5 hrs to fix

    BraintreeForm has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class BraintreeForm extends Model
{
    public $amount;
    public $orderId;
    public $paymentMethodToken;
    Severity: Minor
    Found in src/BraintreeForm.php - About 3 hrs to fix

      Braintree has 29 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Braintree extends Component
{
    public $environment = 'sandbox';
    public $merchantId;
    public $publicKey;
      Severity: Minor
      Found in src/Braintree.php - About 3 hrs to fix

        Method rules has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function rules(): array
    {
        return [
            [['amount'], 'number'],
        Severity: Major
        Found in src/BraintreeForm.php - About 2 hrs to fix

          Function addErrorFromResponse has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function addErrorFromResponse(Error $result)
    {
        $this->lastError = $result;
        $errors = $result->errors;
        foreach ($errors->shallowAll() as $error) {
          Severity: Minor
          Found in src/BraintreeForm.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method attributeLabels has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function attributeLabels(): array
    {
        return [
            'amount' => 'Amount',
            'orderId' => 'Order ID',
          Severity: Minor
          Found in src/BraintreeForm.php - About 1 hr to fix

            Function setOptions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function setOptions(array $values): Braintree
    {
        if (!empty($values)) {
            foreach ($values as $key => $value) {
                if ($key === 'amount') {
            Severity: Minor
            Found in src/Braintree.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getValuesFromAttributes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getValuesFromAttributes(): array
    {
        $values = [];
        foreach ($this->attributes as $key => $val) {
            if (!is_object($val) && !is_null($val) && strlen($val) > 0) {
            Severity: Minor
            Found in src/BraintreeForm.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language