Sign upLogin

dobtco/dispatch

View on GitHub
Star

Showing 7 of 7 total issues

Class Opportunity has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class Opportunity < ActiveRecord::Base
  include PgSearch

  has_storage_unit
Severity: Minor
Found in app/models/opportunity.rb - About 2 hrs to fix

    Method sortable_table_header has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def sortable_table_header(objects, key, name)
    filterer = objects.filterer

    content_tag(
      :a,
    Severity: Minor
    Found in app/helpers/application_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method pick has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def pick(obj, *keys)
    stringified_keys = keys.map(&:to_s)

    {}.tap do |h|
      if obj.is_a?(Hash)
    Severity: Minor
    Found in app/helpers/pick_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sortable_table_header has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def sortable_table_header(objects, key, name)
    filterer = objects.filterer

    content_tag(
      :a,
    Severity: Minor
    Found in app/helpers/application_helper.rb - About 1 hr to fix

      Method status_key has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def status_key
    if !approved?
      if submitted_for_approval?
        :pending_approval
      else
      Severity: Minor
      Found in app/models/opportunity.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method formatted_timestamp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def formatted_timestamp(time, format)
    # If we're in the current year, don't display the year
    if format == :long && time.year == Time.now.year
      format = :long_no_year
    end
      Severity: Minor
      Found in app/helpers/formatted_timestamp_helper.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def update
    authorize @opportunity, :edit?

    if @opportunity.update(opportunity_params)
      if params[:rename]
      Severity: Minor
      Found in app/controllers/opportunities_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language